[fixed] Kessig Wolf Run not trampling PWs

[gnomefry]

Describe the Bug:

When attacking a planeswalker, my blocked creature's Kessig Wolf Run bonus doesn't trample excess damage onto the PW. The creature acquires the trample icon and indeed tramples, but unsoaked damage instead goes to the PW's controller.

When I reload the save and repeat the scenario using a Chorus of Might instant instead of the Kessig land, the creature's excess damage properly spills over to the PW.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)

Holidays 2021 ad1a6f8 - gauntlet

What exactly should be the correct behavior/interaction?

Trample spills damage in excess of the defender's toughness onto the PW target.

Are any other cards possibly affected by this bug?

[drool66]

Confirmed on your save, but not in dev. I don't know how or when this would have been fixed though.
Unrelated, tap_card() needs to be removed from EVENT_ACTIVATE of Kessig Wolf Run

[Aswan jaguar]

The issue happens in dev, too. However the bug happens only when the attacker has bigger game id than Kessig Wolf Run. If attacker has lesser game id than Kessig Wolf Run then it tramples over to planeswalker.

[drool66]

I don't see any reason that damage cards need to wait until EVENT_DEAL_DAMAGE to load the planeswalker being attacked into targets[4] - I think that can be done right in damage_creature() like this:

Code: Select all

  if (attacking)
   {
     if (current_phase == PHASE_FIRST_STRIKE_DAMAGE)
      dmg_inst->token_status |= STATUS_FIRST_STRIKE_DAMAGE;

     if (current_phase == PHASE_NORMAL_COMBAT_DAMAGE)
      dmg_inst->token_status |= STATUS_COMBAT_DAMAGE;

     if( (dmg_inst->token_status & (STATUS_FIRST_STRIKE_DAMAGE|STATUS_COMBAT_DAMAGE)) &&
               check_special_flags(src_player, src_card, SF_ATTACKING_PWALKER) )
      {
        dmg_inst->targets[4].player = 1-src_player;
        dmg_inst->targets[4].card = planeswalker_its_attacking(src_player, src_card);
      }
   }

...and then remove the relevant section from the attacking_planeswalker() legacy code. This does fix this bug, and maybe others; not sure if it complicates anything else. I'm also not sure if it ignores a bigger issue with keyword abilities.

Unrelated, the Soulfire Grand Master section needs to come after the sp_keywords are loaded into the damage card so the added SP_KEYWORD_LIFELINK bit isn't overwritten (my fault)

[EDIT] oh, duh. If the card order is wrong, the damage card will read its targets[4] before the attacking_planeswalker() legacy can change it since it's all done on EVENT_DEAL_DAMAGE

[drool66]

Fixed in f868fb1

[Aswan jaguar]

Now all damage tramples over to Planeswalker and the blocking creature doesn't receive combat damage at all.

[drool66]

I see. The handling will have to be tweaked, but hopefully not overhauled completely.
[EDIT] I have it handled as far as I can tell, continuing to test.
[EDIT2] Changes pushed in bf4d5d7; hopefully we can find a way to do this without rebuilding the data, but it works for now.