[fixed] Inspiring Statuary double-pay and non-permanents

[gnomefry]

Describe the Bug:

This bug was confusing for me due to how situational it could be. I'll try my best to explain what I'm seeing.

Part 1 - Spells that already have Improvise

When Inspiring Statuary is in play and I cast a spell that inherently has Improvise and also doesn't result in a permanent coming into play, I'm asked to pay for the spell a second time. If I use Improvise as any part of that second payment, the spell fails.

I tested with Metallic Rebuke, an instant which has its own Improvise. The spell fails.

I tested with Barricade Breaker, a creature which has its own Improvise. The spell works.


Part 2 - Non-Permanent-resulting spells that don't normally have Improvise

When Inspiring Statuary is in play and I cast a spell that does not normally have Improvise and doesn't result in a permanent being put in play, using Improvise causes the spell to fail.

I tested with the instant Disallow. The spell fails.

I tested with the sorcery Baral's Expertise. The spell fails.

I tested with the instant Cackling Counterpart (this instant results in a token). It works.

I tested with the enchantment Anointed Procession. It works.


Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)

Holidays 2021 ad1a6f8 - gauntlet

What exactly should be the correct behavior/interaction?

You should have to pay only once, and non-permanent spells should work.

Are any other cards possibly affected by this bug?

[drool66]

I've fixed this in the Manalink way, but it will break with anything that has something like convoke, delve, and probably anything with any other cost reduction. I'll try to eventually build this into count_mana(), pay_spell_cost(), compute_and_check_casting_cost()...
[EDIT] ugh... never mind. It can't be done the normal way because of how we make spells free, then charge mana separately. We'd have to make this an activation of Inspiring Statuary thing and I just can't any more with that. It's a big job but I'm going to look at the above functions to see if I can get this change made before release.

[drool66]

Patched in 98ea6a3; I wouldn't say fixed, but that will take some bigger changes