Page 1 of 1

[fixed] damage_dealt_by_me() bad params

PostPosted: 13 May 2022, 19:20
by gnomefry
I'll put this up here and you folks can decide if it's worth looking at!

I don't know which card or combination of cards is causing the below string of 6 errors and then a crash. Aqueous Form 's in-combat scry effect and an instant imprinted to an equipment that triggers on combat dmg to opponent might be interacting poorly. In debug mode I can bury one or the other and the combat completes without a full crash.

Each of the below 6 screenshots is a separate, consecutive pop-up. The first 3 are get_card. Similar except going from 23 to 24 lines of data. Then an in_play error followed by another get_card and finally a call_card. Clicking OK to that one crashes to desktop.

aqueous.jpg
aqueous2.jpg
aqueous3.jpg
aqueous4.jpg
aqueous5.jpg
aqueous6.jpg



Savegame attached: Holidays 2021 ad1a6f8 - gauntlet

Thank you.

Re: [fixed] Error string (rename if you can ID cause)

PostPosted: 16 May 2022, 05:44
by drool66
Bad params in damage_dealt_by_me_arbitrary(). This has been fixed with a band-aid checking p/c parameters (it should probably just check event instead). I'm having trouble with git blame at the moment, but it has been since the December patch.