Page 436 of 505

[fixed by Korath]Ethereal Armor+Ancestral Mask

PostPosted: 02 Jun 2013, 08:12
by Korath
Describe the Bug:
Memnite enchanted by both Ethereal Armor and Ancestral Mask, Enchanted Evening, and five random lands in play under my control. Memnite is only 8/8 (base 1/1, +3/+3 from Ethereal Armor seeing three enchantments, +4/+4 from Ancestral Mask seeing two enchantments other than itself) instead of getting boosts from the enchantment lands and enchantment artifact creature.

Which card did behave improperly ?
Both Ethereal Armor and Ancestral Mask, slightly differently.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/testing for this savegame (first observed in challenge gauntlet).

What exactly should be the correct behavior/interaction ?
Each of the two auras should count cards that are made into enchantments by Enchanted Evening, instead of just "natural" enchantments. Thus the Memnite should be 26/26 (an additional +1/+1 from Ethereal Armor and +2/+2 from Ancestral Mask for each of the lands and for the Memnite itself).

Are any other cards possibly affected by this bug ?
None that I've found.

Hope you have better luck with the savegame than I; I haven't ever been able to reload one.

Fixed by the following patch (though the counts will be too high unless the diff I posted here, or an equivalent, is applied as well):
Code: Select all
diff --git a/src/cards/mercadian_masques.c b/src/cards/mercadian_masques.c
index df34b89..b8c218e 100644
--- a/src/cards/mercadian_masques.c
+++ b/src/cards/mercadian_masques.c
@@ -206,11 +206,7 @@ int card_alley_grifters(int player, int card, event_t event ){

 int card_ancestral_mask(int player, int card, event_t event ){

-    target_definition_t td;
-    default_target_definition(player, card, &td, TYPE_ENCHANTMENT);
-       td.illegal_abilities = 0;
-
-       int plus = 2*(target_available(player, card, &td)-1);
+       int plus = 2*(count_subtype(2, TYPE_ENCHANTMENT, -1)-1);
        if( plus < 0 ){
                plus = 0;
        }
diff --git a/src/cards/return_to_ravnica.c b/src/cards/return_to_ravnica.c
index 69bb132..e2026a9 100644
--- a/src/cards/return_to_ravnica.c
+++ b/src/cards/return_to_ravnica.c
@@ -413,8 +413,9 @@ int card_bazaar_krovod(int player, int card, event_t event){

 int card_ethereal_armor(int player, int card, event_t event){

+       int plus = count_subtype(player, TYPE_ENCHANTMENT, -1);
        return generic_aura(player, card, event, player,
-                                               count_permanents_by_type(player, card, TYPE_ENCHANTMENT), count_permanents_by_type(player, card, TYPE_ENCHANTMENT),
+                                               plus, plus,
                                                KEYWORD_FIRST_STRIKE, 0, 0, 0, 0);
 }


Re: Enchanted Evening + Ethereal Armor or Ancestral Mask

PostPosted: 02 Jun 2013, 08:16
by Aswan jaguar
You can attach a screenshot when it helps like this case when savegames are corrupted you can use FastStone Image Viewer if you don't have one to capture the screen-shot.
EDIT:Your savegame is ok.

Re: Enchanted Evening + Ethereal Armor or Ancestral Mask

PostPosted: 02 Jun 2013, 08:32
by Korath
Aswan jaguar wrote:EDIT:Your savegame is ok.
Once in a while I get the "Couldn't load the save game; corrupt file or from a different version" popup; the rest of the time, manalink hangs indefinitely at 100% cpu. Makes testing fixes a pain. Didn't think of screenshots, though.

[fixed by Gargaroz]Teysa, Orzhov Scion not activateable

PostPosted: 02 Jun 2013, 09:01
by Korath
Describe the Bug:
Teysa, Orzhov Scion doesn't seem to be activateable no matter what I do. I have three Soldier tokens (from Timely Reinforcements, confirmed white because they're pumped by Honor of the Pure) in play that I could sacrifice to her and plenty of creatures to target. I've also reproduced this with non-token white creatures.

Which card did behave improperly ?
Teysa, Orzhov Scion.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none for this savegame (first observed in challenge gauntlet).

What exactly should be the correct behavior/interaction ?
Teysa, Orzhov Scion should be able to activate to sacrifice three white creatures to exile a target creature.

Are any other cards possibly affected by this bug ?
Seems isolated.

Re: Devout Chaplain: taps but doesn't exile

PostPosted: 02 Jun 2013, 12:41
by Gargaroz
Fixed.

Re: Zuberi, Golden Feather

PostPosted: 02 Jun 2013, 12:44
by Gargaroz
Recoded & fixed.

Re: Energy Bolt can target creatures.

PostPosted: 02 Jun 2013, 12:45
by Gargaroz
Fixed.

Re: Morkrut Banshee morbid ability doesn't work

PostPosted: 02 Jun 2013, 12:50
by Gargaroz
Fixed.

Re: Ghostly Possession doesn't attach to creature.

PostPosted: 02 Jun 2013, 12:54
by Gargaroz
Fixed.

Re: Baneful Omen

PostPosted: 02 Jun 2013, 12:56
by Gargaroz
All fixed.

Re: Razor Pendulum triggers at beginning of upkeep.

PostPosted: 02 Jun 2013, 13:00
by Gargaroz
Fixed.

Re: [confirmed]Rise of the Hobgoblins

PostPosted: 02 Jun 2013, 13:33
by Gargaroz
Fixed, and thanx Korath ;)
For the tokens : the color is changed via coding when they're putted into play. We use "vanilla" tokens that are altered to match the card by the card code.

Re: [fixed by Korath]Enchanted Evening + Yavimaya Enchantres

PostPosted: 02 Jun 2013, 13:35
by Gargaroz
The bugs with Enchanted Evening were already fixed, but thanks anyway.

Re: Carrion puts 1/1 insects

PostPosted: 02 Jun 2013, 13:39
by Gargaroz
Fixed.

Re: [fixed by Korath]Ethereal Armor+Ancestral Mask

PostPosted: 02 Jun 2013, 13:41
by Gargaroz
Fixed inserted, thank you Korath.