Collectible Card Game Headquarters

Fixed.

Fixed.

Fixed.

No, it should be fixed for all.

Describe the Bug:
I control a Mountain and Urborg, Tomb of Yawgmoth. I activate urborg and target itself; it taps and produces . I then activate urborg and target the mountain; the mountain taps and produces , but urborg untaps.

Which card did behave improperly ?
Urborg, Tomb of Yawgmoth.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none.

What exactly should be the correct behavior/interaction ?
Urborg, Tomb of Yawgmoth should neither tap nor untap itself when activating to tap another land for .

Are any other cards possibly affected by this bug ?
No.

Code: Select all

diff --git a/src/cards/planar_chaos.c b/src/cards/planar_chaos.c
index 18c6f91..8a1c531 100644
--- a/src/cards/planar_chaos.c
+++ b/src/cards/planar_chaos.c
@@ -2833,10 +2833,12 @@ int card_urborg_tomb_of_yawgmoth(int player, int card, event_t event){

        if(event == EVENT_ACTIVATE ){
                if( pick_target(&td, "TARGET_LAND") ){
+                       int was_tapped;
                        tap_card(instance->targets[0].player, instance->targets[0].card);
                        instance->number_of_targets = 1;
+                       was_tapped = instance->state & STATE_TAPPED;
                        mana_producer(player, card, event);
-                       if( ! (instance->targets[0].player == player && instance->targets[0].card == card) ){
+                       if( !was_tapped ){
                                untap_card(player, card);
                        }
                }

Describe the Bug:
Sowing Salt targets a non-basic land and nothing happens,it stays on hand.

Which card did behave improperly ?
Sowing Salt

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
ML3-MAY\2013

What exactly should be the correct behavior/interaction ?


Are any other cards possibly affected by this bug ?

Describe the Bug:
Spreading Seas makes its enchanted land into a swamp.

Which card did behave improperly ?
Spreading Seas.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none.

What exactly should be the correct behavior/interaction ?
The enchanted land should be an island.

Are any other cards possibly affected by this bug ?
No. Evil Presence and Contaminated Ground work properly, and other similar cards (Lingering Mirage and Sea's Claim) aren't coded.

Code: Select all

diff --git a/src/cards/zendikar.c b/src/cards/zendikar.c
index 181d256..b5fae9a 100644
--- a/src/cards/zendikar.c
+++ b/src/cards/zendikar.c
@@ -4723,6 +4723,14 @@ int card_spreading_seas(int player, int card, event_t event){
         instance->info_slot = COLOR_BLUE;
         draw_a_card(player);
     }
+
+    if( event == EVENT_CHANGE_TYPE ){
+        if (affect_me(instance->targets[0].player, instance->targets[0].card)){
+            event_result = get_hacked_color(player, card, 2) - 1;
+        }
+        return 0;
+    }
+
     return card_evil_presence(player, card, event);
 }



card_evil_presence() in the exe also does some other stuff (a call to 0x401A40 and a check for !(land_can_be_played & 2)) in its EVENT_CHANGE_TYPE handler. I haven't a clue what they do, but can't find any obvious side effects of omitting them.

Describe the Bug:
Cloudpost doesn't tap when activated, and only adds for each Locus you control.

Which card did behave improperly ?
Cloudpost.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none.

What exactly should be the correct behavior/interaction ?
It should tap, and should add for each Locus on the battlefield (including the other player's).

Are any other cards possibly affected by this bug ?
No. Glimmerpost correctly counts the number of Locuses.

Code: Select all

diff --git a/src/cards/lands.c b/src/cards/lands.c
index bed9124..acada6e 100644
--- a/src/cards/lands.c
+++ b/src/cards/lands.c
@@ -436,13 +436,14 @@ int card_cloudpost(int player, int card, event_t event){
     comes_into_play_tapped(player, card, event);

     if( event == EVENT_COUNT_MANA && !(is_tapped(player, card)) && affect_me(player, card) ){
-        declare_mana_available(player, COLOR_COLORLESS, count_subtype(player, TYPE_LAND, SUBTYPE_LOCUS) );
+        declare_mana_available(player, COLOR_COLORLESS, count_subtype(2, TYPE_LAND, SUBTYPE_LOCUS) );
     }
     else if(event == EVENT_CAN_ACTIVATE && !(is_tapped(player, card)) ){
                        return 1;
     }
     else if( event == EVENT_ACTIVATE){
+                       tap_card(player, card);
-                       produce_mana(player, COLOR_COLORLESS, count_subtype(player, TYPE_LAND, SUBTYPE_LOCUS));
+                       produce_mana(player, COLOR_COLORLESS, count_subtype(2, TYPE_LAND, SUBTYPE_LOCUS));
     }

     return 0;


edit:struck already-fixed parts

Thanks,this bug was a pain in the ass for years thanks for fixing it.I imagine you tested the fix,right?

If actually only works on basic lands, though it can't be cast unless there's a nonbasic land in play.

Code: Select all

diff --git a/src/cards/urza_destiny.c b/src/cards/urza_destiny.c
index 7f5b1f3..44f7f74 100644
--- a/src/cards/urza_destiny.c
+++ b/src/cards/urza_destiny.c
@@ -2229,7 +2229,7 @@ int card_sowing_salt(int player, int card, event_t event){
     else if( event == EVENT_CAST_SPELL && affect_me(player, card) ){
             if( pick_target(&td, "TARGET_LAND") ){
                                instance->number_of_targets = 1;
-                if( ! is_basic_land(instance->targets[0].player, instance->targets[0].card) ){
+                if( is_basic_land(instance->targets[0].player, instance->targets[0].card) ){
                                        spell_fizzled = 1;
                 }
             }


Yes, and with Magical Hacks altering it also.

Already reported and fixed here

Ack, sorry - I did search, and somehow overlooked that.

The other half, that it doesn't count the opponent's Locuses, wasn't reported there, though.

Ah right, adding bug then, will have to check if Gargaroz noticed it too.

Describe the Bug:
Mindlock Orb is highlighted as castable even if the mana requirement is not met

Which card did behave improperly ?
Mindlock Orb

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
PM

What exactly should be the correct behavior/interaction ?
Mindlock Orb is not highlighted as castable if the mana requirement is not met

Are any other cards possibly affected by this bug ?
-