[fixed]Life Chisel gains too much life.

by **Aswan jaguar** » 03 Jan 2019, 16:48

Describe the Bug:
Life Chisel ability gains too much life if I am not wrong it has to do with creature's id and something else.
e.g I sacrificed Ayli, Eternal Pilgrim and got from 25 life to 15650 life. Ayli's id is 15555.

Which card did behave improperly?
Life Chisel

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink dev 778ccb5 version - duel

What exactly should be the correct behavior/interaction?
Life Chisel :sacrifice a creature: You gain life equal to the sacrificed creature's toughness.

Are any other cards possibly affected by this bug?
-

by **Korath** » 03 Jan 2019, 17:57

It's Ayli's iid (which is 15629); 15555 is Ayli's csvid. Caused by the latter half of generic_activated_ability_with_sacrifice_as_cost() querying flags instead of sac_flags.

by **Aswan jaguar** » 04 Jan 2019, 10:53

I fixed this, thanks Korath you saved me posting many reports that were caused by this bug. Hopefully I didn't introduce bugs that need explicit testing.
Also fixed that it triggered on each upkeep in 3578e03902731...