[fixed] TYPE_NONCREATURE doesn't mean that

[Korath]

(Sorry for not using the form, it's a bad fit and I haven't actually tested this, or even built yet.)

Everything here also applies to the similarly-new TYPE_NONLAND.

Code: Select all

TYPE_NONCREATURE      = TYPE_LAND | TYPE_ENCHANTMENT | TYPE_ARTIFACT | TYPE_SPELL,

Defining TYPE_NONCREATURE like that, and then using it in a form that eventually becomes "type & TYPE_NONCREATURE" - as just about all current uses do - doesn't mean "is only one or more of land, enchantment, artifact, instant, interrupt, or sorcery", it means "is one or more of enchantment, artifact, instant, interrupt, or sorcery". That is, is_what(cardid, TYPE_NONCREATURE) will be true for Dryad Arbor, Lucent Liminid, Obsianus Golem, and Visitor from Planet Q. You really do have to end up using !(type & TYPE_CREATURE). Should be easiest to test with Fae of Wishes // Granted.

[drool66]

Thanks, Korath
Fixed, currently checking full functionality.
EDIT: fixed in 81dc2e4