[fixed] New alert and crash to desktop. (playing Khalni Gem)

by **etphonehome** » 14 Aug 2021, 15:35

New alert and crash to desktop...

by **cardscan12** » 15 Aug 2021, 02:48

This looks like a memory dump, I'll look into it. Can you give me details as to what you were doing leading up to the error so I can try to reproduce it?

by **etphonehome** » 15 Aug 2021, 09:40

The game crashes when i play Khalni Gem.

THX

by **drool66** » 15 Aug 2021, 15:44

Khalni Gem isn't validating its targets. Fixed, uncommitted

by **Korath** » 15 Aug 2021, 16:33

It doesn't need to validate; there's no opportunity for a response between selection and bouncing for the "targets" to become invalid. The problem here is that new_pick_target(&td, "Select a land you control.", 0, GS_LITERAL_PROMPT) is saying to store the selected permanent in card_instance_t::targets[0] for both lands, instead of the first in targets[0] and second in targets[1]. You want to pass either -1 or i instead of 0 for the third argument.

by **drool66** » 17 Aug 2021, 18:13

Yessir, that's it. Fixed in 23b95b9