[fixed]Lost Legacy forces selection from library

[Korath]

Describe the Bug:
When I cast Lost Legacy to test name selection, naming Abjure, a card that isn't in the AI's deck, I'm continuously prompted to "Select a card named Abjure to exile." showing its library.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
dev 51b6a316a, duel.

What exactly should be the correct behavior/interaction?
If I click "Done", the dialog should go away, no matter what. Selecting a card when searching a hidden zone is never mandatory even if, unlike here, a selectable card is in it. (And even if the zone's currently revealed by some other effect.)

Are any other cards possibly affected by this bug?
It's plainly somewhere in lobotomy_effect(), not card_lost_legacy() itself.

[drool66]

I'm really sorry about this, Korath - it's a probationary change I made to new_global_tutor() for the Ikoria drafts in 73cc6a, specifically for Fire Prophecy I think. For the moment it returns -2 if a player can tutor but chooses not to, as opposed to -1 if he cannot tutor and therefore doesn't. lobotomy_effect() is one of the 80 or so places that compares the output of new_global_tutor() to != -1; comparing to >= 0 fixes this. I pushed earlier than I had intended because Aswan jaguar needed the addresses in ManalinkEh.asm for his cards. This will be cleared up before Ikoria is finalized.

[drool66]

Fixed in e87950a

[Aswan jaguar]

Just a reminder that you didn't push this or any the other commits yet, so their id will change if someone else pushes a commit.

[drool66]

Oh shoot, I'm seeing them as pushed - commit is "Complete IKO et al drafts from 73cc6ad" [e87950a] 14.11.21. You don't see that one?
(it's included in that commit because I made a change to new_global_tutor() with the IKO drafts that caused this bug)

[Korath]

It's there, complete with irritating byte-order-mark at the start of the commit message.

[Aswan jaguar]

I am sorry, my bad I thought this was about a new commit and I didn't check the commit id as I should have done.