[fixed] Whippoorwill legacy at cleanup
Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins
[fixed] Whippoorwill legacy at cleanup
by Korath » 18 Nov 2021, 23:14
Describe the Bug:
Whippoorwill's legacy crashes at cleanup (apparently immediately after selecting a target when activating, due to AI speculation).
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
dev 913cddcc6.
What exactly should be the correct behavior/interaction?
Not that.
Are any other cards possibly affected by this bug?
No, looks like the effect card doesn't get attached to anything.
#0 show_backtrace (title=title@entry=0x2683cda <words+378> "bad parameters", header=header@entry=0x1998fc10 "get_card_instance(-1, -1)") at functions/show_backtrace.c:16
#1 0x025ef3e2 in get_card_instance (player=player@entry=-1, card=card@entry=-1) at functions/deck.c:303
#2 0x025ca108 in remove_status (player=-1, card=-1, st=st@entry=8388608) at functions/functions.c:7618
#3 0x023a8d97 in whippoorwill_legacy (player=0, card=14, event=EVENT_CLEANUP) at cards/the_dark.c:3852
#4 0x00457e4a in fx_custom_903 () at Magic2.asm:60003
#5 0x0262ced5 in call_card_fn_impl () from .\ManalinkEh.dll
#6 0x025b96bc in call_card_fn (address=0x457e10 <fx_custom_903>, instance=0x4f05a8 <sub_4E9564+28740>, player=player@entry=0, card=card@entry=14, event=event@entry=EVENT_CLEANUP) at functions/events.c:51
#7 0x025b9e49 in call_card_function_i (event=EVENT_CLEANUP, card=14, player=0, instance=<optimized out>) at functions/events.c:30
#8 dispatch_event_to_single_card (player=0, card=14, event=EVENT_CLEANUP, new_attacking_card_controller=1, new_attacking_card=-1) at functions/events.c:271
#9 0x0043d287 in cleanup_phase () at Magic2.asm:45864
#10 0x00439a04 in run_turn () at Magic2.asm:44078
#11 0x0047902c in start_duel () at Magic2.asm:76779
#12 0x004946e9 in start_duel_thread () at Magic2.asm:89827
#13 0x76ebfa29 in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\SysWOW64\kernel32.dll
#14 0x77cc7a9e in ntdll!RtlGetAppContainerNamedObjectPath () from C:\WINDOWS\SysWOW64\ntdll.dll
#15 0x77cc7a6e in ntdll!RtlGetAppContainerNamedObjectPath () from C:\WINDOWS\SysWOW64\ntdll.dll
#16 0x00000000 in ?? ()
Whippoorwill's legacy crashes at cleanup (apparently immediately after selecting a target when activating, due to AI speculation).
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
dev 913cddcc6.
What exactly should be the correct behavior/interaction?
Not that.
Are any other cards possibly affected by this bug?
No, looks like the effect card doesn't get attached to anything.
#0 show_backtrace (title=title@entry=0x2683cda <words+378> "bad parameters", header=header@entry=0x1998fc10 "get_card_instance(-1, -1)") at functions/show_backtrace.c:16
#1 0x025ef3e2 in get_card_instance (player=player@entry=-1, card=card@entry=-1) at functions/deck.c:303
#2 0x025ca108 in remove_status (player=-1, card=-1, st=st@entry=8388608) at functions/functions.c:7618
#3 0x023a8d97 in whippoorwill_legacy (player=0, card=14, event=EVENT_CLEANUP) at cards/the_dark.c:3852
#4 0x00457e4a in fx_custom_903 () at Magic2.asm:60003
#5 0x0262ced5 in call_card_fn_impl () from .\ManalinkEh.dll
#6 0x025b96bc in call_card_fn (address=0x457e10 <fx_custom_903>, instance=0x4f05a8 <sub_4E9564+28740>, player=player@entry=0, card=card@entry=14, event=event@entry=EVENT_CLEANUP) at functions/events.c:51
#7 0x025b9e49 in call_card_function_i (event=EVENT_CLEANUP, card=14, player=0, instance=<optimized out>) at functions/events.c:30
#8 dispatch_event_to_single_card (player=0, card=14, event=EVENT_CLEANUP, new_attacking_card_controller=1, new_attacking_card=-1) at functions/events.c:271
#9 0x0043d287 in cleanup_phase () at Magic2.asm:45864
#10 0x00439a04 in run_turn () at Magic2.asm:44078
#11 0x0047902c in start_duel () at Magic2.asm:76779
#12 0x004946e9 in start_duel_thread () at Magic2.asm:89827
#13 0x76ebfa29 in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\SysWOW64\kernel32.dll
#14 0x77cc7a9e in ntdll!RtlGetAppContainerNamedObjectPath () from C:\WINDOWS\SysWOW64\ntdll.dll
#15 0x77cc7a6e in ntdll!RtlGetAppContainerNamedObjectPath () from C:\WINDOWS\SysWOW64\ntdll.dll
#16 0x00000000 in ?? ()
Last edited by drool66 on 19 Nov 2021, 22:18, edited 1 time in total.
Reason: fixed
Reason: fixed
-
Korath - DEVELOPER
- Posts: 3707
- Joined: 02 Jun 2013, 05:57
- Has thanked: 496 times
- Been thanked: 1106 times
Re: Whippoorwill legacy at cleanup
by drool66 » 19 Nov 2021, 22:18
Just needs to create_targetted_legacy_effect() instead of create_legacy_effect()
Fixed in 61d08b0
Fixed in 61d08b0
Last edited by drool66 on 28 Nov 2021, 03:07, edited 1 time in total.
Reason: hash info
Reason: hash info
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1163
- Joined: 25 Nov 2010, 22:38
- Has thanked: 186 times
- Been thanked: 267 times
2 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 98 guests