[fixed]Arrest does not prevent creature from blocking

by **Blyfycyfyfyf** » 23 Dec 2021, 14:11

Describe the Bug:
Arrest should have Pacifism-like effect. However AI is still blocking with "Arrested" creature.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Holidays 2021, duel.

What exactly should be the correct behavior/interaction?
Arrest should not allow a creature to block.

Are any other cards possibly affected by this bug?
No.

Just please attack with the 8/7 guy in the savegame - AI will block with "Arrested" creature.

by **drool66** » 23 Dec 2021, 19:19

Fixed in 51af4e8. It used the old add/remove system of ability loss

by **Aswan jaguar** » 25 Dec 2021, 09:17

The problem here was and still is that creature enchanted with Arrest can still block. It did stop activated abilities before. Same bug as One Thousand Lashes reported now.

by **Korath** » 25 Dec 2021, 13:39

It's incorrectly making the blocking card return nonzero for is_humiliated(..., AL_KEY), which (separately) incorrectly prevents SP_KEYWORD_CANNOT_BLOCK from doing anything.

by **drool66** » 27 Dec 2021, 20:16

Weird. I didn't think the meaning of any of the generic_aura_flags_t drifted, but now I'm not so sure. Fixed for arrest & cards that share its function, unpushed.