[fixed]Ulamog's Nullifier no counter

[gnomefry]

Describe the Bug:

Ulamog's Nullifier isn't coming into play with the option to transfer exiles to the GY and counter target spell.

The attached save has multiple exiled cards from sources like Spell Queller, Transgress the Mind, Anguished Unmaking, and two Oblivion Ring (which have their exiled card names visible on the board).

Fixed once 2016: viewtopic.php?f=110&t=18334&hilit=ulamog%27s+nullifier

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)

Holidays 2021 ad1a6f8 - gauntlet

What exactly should be the correct behavior/interaction?

Wasteland Strangler has a move-exile-to-graveyard dialog box that works well. Maybe that can be used for template? Thanks as always for your work.

Are any other cards possibly affected by this bug?

[Aswan jaguar]

I confirm this bug.
@drool66 I can only fix this by reverting it back to using comes_into_play() function, which of course will make it not consider Panharmonicon and the other cards that are checked in etb_ability(). Could you take a look?

*Not that we have migrated all cards/functions to use etb_ability(), I still count 75 using comes_into_play() maybe some of those should not be changed.

[drool66]

The only thing keeping etb_ability() from working are the event gates at the top of the card; so

Code: Select all

  if (!IS_CASTING(player, card, event) // sic
     && trigger_condition != TRIGGER_COMES_INTO_PLAY)
   return 0;

should be

Code: Select all

  if (!IS_CASTING(player, card, event) // sic
     && !(event == EVENT_ETB_ABILITY)
     && trigger_condition != TRIGGER_COMES_INTO_PLAY)
   return 0;

I tried to keep an eye out for that kind of thing when I transferred it over to this new system, but I think I thought since EVENT_ETB_ABILITY was fired under TRIGGER_COMES_INTO_PLAY, that would cover it (of course, I was wrong about that. trigger_condition is stashed and set to -1 while the event is fired)

Also, cards can't generally counter more than one spell, so I don't know if we want Ulamog's Nullifier to respond to Panharmonicon et al., except maybe to process more than once?

It's frustrating that we have two functions that did the exact same thing. I can go through and update the ~75 cards.

[EDIT] all done in c48221c