[fixed]Dark Impostor activation crash

by **gnomefry** » 09 Jun 2022, 19:16

Describe the Bug:

Activating Dark Impostor causes a crash to desktop. There's no error pop-up that I can see before it crashes, and dump.txt isn't updated.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)

Holidays 2021 ad1a6f8 - gauntlet

What exactly should be the correct behavior/interaction?

No CTD.

by **drool66** » 10 Jun 2022, 16:19

Well, I've "fixed" it to the point that it won't crash, but its targets array will be overwritten very easily. My big project right now it expanding instance_t::ext to hold a lot more data for this kind of thing; I guess this could be my test case for that.
EDIT: fixed, unpushed
EDIT2: 0885ae8

by **Aswan jaguar** » 19 Jun 2022, 17:50

drool66 the crash doesn't happen.
Does this still need work to work mostly correctly? Because I get erratic behaviour half the times doesn't have the activated abilities of creatures exiled with it on dialog although you have the mana for them and also sometimes instead of prompting the correct kind of mana it prompts only for generic mana of same quantity. For Agent of Horizons I got prompt correctly for {2}

at a time and another time for {3}

.

by **drool66** » 20 Jun 2022, 01:01

It's the special flag bug you messaged me about. What was happening is check_special_flags_2/3() were checking get_special_flags_#() when they should have checked "get_special_flags_#() & value", so setting any flag would be like setting all flags. This bug would probably be due to the "SF2_HAS_DAMAGED_PLAYER1" flag being set on dealing damage, and reading as if "SF2_MYCOSYNTH_LATTICE" is set. Also why dealing damage to opponent meant it could be targeted by Allay - it was reading as if SF2_ENCHANTED_EVENING was set.
ie. yes, this is fixed, and it's actually good to know it interacts properly with Mycosynth Lattice

I just pushed the changes.