Page 1 of 2

[fixed]Deckbuilder Cards Disappear sometimes sort by csvid

PostPosted: 29 Jan 2023, 09:29
by Nekradamus
Describe the Bug:
While deckbuilding, I filter the cards in my pool by color and when I double-click on a card to put it on the deck, all others desapear. To show them back I have to deselect the filter and then filter again. This happens everytime I choose a card to put in the deck.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
October 2022 4040bdb - October 2022 - Rebels & Rhystics to Pathways & Pests: Hotfix. Format : Sealed Deck

What exactly should be the correct behavior/interaction?
Cards left in the pool are not supposed to disapear after each double-click (I guess).

Are any other cards possibly affected by this bug?
n/a

I installed the October 2022 patch "full install".

Re: October 2022 4040bdb

PostPosted: 29 Jan 2023, 13:54
by Aswan jaguar
Please mention/number every step you make to produce this bug because I can't replicate this not with your update nor in dev.

Re: October 2022 4040bdb

PostPosted: 29 Jan 2023, 23:15
by drool66
Nekradamus, additionally please backup and replace your deckdll.dll with the attached file (unzip it first, obviously) and please let us know if that fixes the issue.

Re: October 2022 4040bdb

PostPosted: 31 Jan 2023, 17:02
by Nekradamus
drool66 wrote:Nekradamus, additionally please backup and replace your deckdll.dll with the attached file (unzip it first, obviously) and please let us know if that fixes the issue.
Sorry, didn't work. Same behavior. :cry:

Re: October 2022 4040bdb

PostPosted: 31 Jan 2023, 17:13
by Nekradamus
Aswan jaguar wrote:Please mention/number every step you make to produce this bug because I can't replicate this not with your update nor in dev.
I start a Duel selecting Sealed Deck format

Start Tournament (1 deck + 3 packs of 5th Ed)

Click on "done" (this automaticaly opens the packs and the deck providing the card pool) and sends to the deckbuiling page

On the Deck Building page, using the filters, I unselect all colors but white to have listed only the white cards available in my pool

I double click on one card to put it in the deck

Suddenly all other white cards in the pool disapear

To see again the white cards again I have to unselect the white filter and select it again

Re: October 2022 4040bdb

PostPosted: 31 Jan 2023, 17:40
by Nekradamus
It seems very similar, but not the same as this one: viewtopic.php?f=86&t=31498&hilit=sealed+deck

Re: October 2022 4040bdb

PostPosted: 31 Jan 2023, 18:33
by Aswan jaguar
It seems to be the same issue as the link with the other sealed deck-builder issue.
I missed that you were playing Sealed. #-o

Re: [confirmed]October 2022 4040bdb

PostPosted: 07 Feb 2023, 08:39
by drool66
Appears to be 9a8c26a ("[DECKDLL] don't realloc internal data after every card added to main listbox", 4.4.22)
I have no idea how to fix it though

Re: [fixed]October 2022 4040bdb

PostPosted: 26 Feb 2023, 04:47
by drool66
Here is a file that fixes the problems, but I'm not sure it does so in the most efficient way. Committed in 8db6bdf
By downloading this file, you agree that you will:
  • Back up your current deckdll.dll
  • Post any bugs you find in deckbuilder with the patch "October 2022 - Rebels & Rhystics to Pathways & Pests: Hotfix", and document that you have this modified file.

mediafire.com/file/o5pgs176a2r5p5d/DeckDll.zip/file

Re: [fixed]Deckbuilder Cards Disappear; sometimes sort by cs

PostPosted: 28 Feb 2023, 15:16
by Aswan jaguar
I did some testing with sealed deckbuilder and normal Manalink one with no apparent issues.
I didn't test at all shandalar deckbuilder which shares more code with sealed deckbuilder.

Re: [fixed]Deckbuilder Cards Disappear; sometimes sort by cs

PostPosted: 01 Mar 2023, 18:04
by drool66
There is still a sorting issue, maybe you can confirm? Typing will always send to the beginning of the list. I do have a fix for this too; trying to make sure it doesn't clobber Korath's sorting algorithm.

Re: [fixed]Deckbuilder Cards Disappear; sometimes sort by cs

PostPosted: 01 Mar 2023, 18:22
by Aswan jaguar
I confirm the issue for sealed deckbuilder when typing outside search box.

Re: [fixed]October 2022 4040bdb

PostPosted: 03 Mar 2023, 00:45
by rianannalan
drool66 wrote:Here is a file that fixes the problems, but I'm not sure it does so in the most efficient way. Committed in 8db6bdf
By downloading this file, you agree that you will:
  • Back up your current deckdll.dll
  • Post any bugs you find in deckbuilder with the patch "October 2022 - Rebels & Rhystics to Pathways & Pests: Hotfix", and document that you have this modified file.
New install from the Oct 2022 update, was experiencing this bug too. Cheers for the fix, much preferred to phasing cards while deckbuilding!

I note that with the updated .dll, when attempting to add multiple cards to your deck from a single card instance (such as adding basic land), the program makes the No sound & you can't add another card until you move the cursor off of that card.

Thanks again for keeping the dream alive!

Re: [fixed]Deckbuilder Cards Disappear; sometimes sort by cs

PostPosted: 03 Mar 2023, 14:39
by Aswan jaguar
rianannalan wrote:I note that with the updated .dll, when attempting to add multiple cards to your deck from a single card instance (such as adding basic land), the program makes the No sound & you can't add another card until you move the cursor off of that card.
I confirm this behaviour. The issue is not with adding multiple cards but with card position. So if you click and select a card which goes to created deck and then from same position of mouse where previous card was you try to get the card that took it's place you get what rianannalan says above.

Also guys you can select multiple cards with (shift+double left click). You get a select a number menu and you can select up to as many as you have drafted. Same for deselect cards from deck.

Re: [fixed]Deckbuilder Cards Disappear; sometimes sort by cs

PostPosted: 01 May 2023, 19:40
by drool66
Finally managed to fix everything properly in f9c7950 after working on this almost exclusively for about 4 months