It is currently 13 Nov 2019, 16:50
   
Text Size

Development thread

Moderators: melvin, beholder, ubeefx, ShawnieBoy, Lodici, CCGHQ Admins

Development thread

Postby Lodici » 21 May 2014, 06:24

re: https://groups.google.com/forum/#!topic ... C8Cw9O9GUw
Looks fine except the amended CardsMissingInMagarena.txt is incorrect. See https://bitbucket.org/lodici/magarenasc ... ent-962901.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Development thread

Postby Lodici » 21 May 2014, 10:35

Whilst looking into adding an option that will let you specify a custom location for storing card images I came across the "resources/magic/data/images.txt" file. This file is practically obsolete except for the fact that it is used to specify an additional image for each basic Land card. It is used in conjunction with the num_images property in the script file but the whole thing seems a bit inconsistent - why have a second image for the basic lands but not for other cards? Then when it draws a Hand it kind of pseudo-randomly picks the image to use so you can end up with different images for the same card type (eg. three types of forest)...
hand.png

I have since worked out a way to do away with images.txt and the num_images property and specify multiple images using the image property in the script file. Using this approach you could define any number of alternative images for any card, but is this really desirable? Personally, I would prefer a single image per card type although it might be nice to be able to select the particular image you want to use. Or should we just stick to one default image per card at this stage until we can come up with a consistent way of managing multiple images per card?
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Development thread

Postby ShawnieBoy » 21 May 2014, 12:51

Personally I prefer one image per card (the latest edition - for oracle text clarity, preferably modern bordered and not in foil).

Others will have their own preference, or want a specific art on certain cards (Ice Age Dark Banishing for me, but that's just showing my age). This can already be done by editing the script files.

If we would some-day implement all art versions of a card, putting them onto the script files wouldn't be the way to go.


edit - Good idea with the development thread, but maybe a sub-forum would work better.
User avatar
ShawnieBoy
Programmer
 
Posts: 601
Joined: 02 Apr 2012, 22:42
Location: UK
Has thanked: 80 times
Been thanked: 50 times

Re: Development thread

Postby Lodici » 21 May 2014, 16:33

ShawnieBoy wrote:Personally I prefer one image per card (the latest edition - for oracle text clarity, preferably modern bordered and not in foil).
Ok, unless there are any objections I will remove images.txt and num_images-related code. Each of the five basic land cards will then use the single image as defined in the script file. Nice and simple.

ShawnieBoy wrote:edit - Good idea with the development thread, but maybe a sub-forum would work better. On a plus side, it keeps the forums more active, as at first appearance there's not a lot going on from a dev standpoint.
Easier said than done when you are just a minion! :mrgreen: Melvin is a moderator so maybe he can create the forum. Agree about keeping the forum more active.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Development thread

Postby melvin » 22 May 2014, 00:50

I can't change the forum structure, only the posts. We need either the site admin or forum admin to do that.

My issue with discussing on the forum is that it is hard to have a permanent copy/backup of the content. For mailing list, any of us can just archive all the email sent from the mailing list. Plus it requires a few extra steps to check the forum as compared to email.

The plan is that the forum is for users and the mailing list is for development discussions, where we want to keep a permanent record of what was discussed and decided upon.
User avatar
melvin
AI Programmer
 
Posts: 1057
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 456 times

Re: Development thread

Postby hong yie » 22 May 2014, 02:36

is this mean, there will be no unique picture for duplicate card instance? :(
i think i will forgetting this idea, if its really going to burden the development process.
User avatar
hong yie
Programmer
 
Posts: 216
Joined: 10 Mar 2013, 06:44
Location: Jakarta
Has thanked: 75 times
Been thanked: 9 times

Re: Development thread

Postby Lodici » 22 May 2014, 06:32

hong yie wrote:is this mean, there will be no unique picture for duplicate card instance? :(
i think i will forgetting this idea, if its really going to burden the development process.
Presumably the screenshot above containing three different images of Forest is what you want? Magarena does have a mechanism in place for assigning multiple images to a card but it is currently only used to specify an additional image for each of the five basic land cards and can only be updated by someone familiar with the code base. To me it seems like a half-completed implementation that has fallen into obsolescence. My proposal is to remove this code so that it makes things simpler and to give someone a clear run in the future should they want to implement a more comprehensive multiple image system.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Development thread

Postby hong yie » 22 May 2014, 06:43

Presumably the screenshot above containing three different images of Forest is what you want? Magarena does have a mechanism in place for assigning multiple images to a card but it is currently only used to specify an additional image for each of the five basic land cards and can only be updated by someone familiar with the code base. To me it seems like a half-completed implementation that has fallen into obsolescence. My proposal is to remove this code so that it makes things simpler and to give someone a clear run in the future should they want to implement a more comprehensive multiple image system.
i agree with this code removal, If its only removed temporarily.
i really hope this code will be completed some day. :)
User avatar
hong yie
Programmer
 
Posts: 216
Joined: 10 Mar 2013, 06:44
Location: Jakarta
Has thanked: 75 times
Been thanked: 9 times

Re: Development thread

Postby Lodici » 22 May 2014, 07:12

melvin wrote:My issue with discussing on the forum is that it is hard to have a permanent copy/backup of the content.
Sorry melvin, I don't buy that as a compelling reason for solely using Google. I don't think this site is going anywhere soon and as far as I am aware they keep all posts. The only thing that Google has going for it is the Issue Tracker which is useful but if you can't use it without jumping through hoops because of Google's obsession with trying to profile you then it loses its appeal very quickly (for me anyway). It's not like I have something to hide but we are working on something that is a bit of a grey area when it comes to legality and Google's constant instrusiveness just grates.

melvin wrote:For mailing list, any of us can just archive all the email sent from the mailing list. Plus it requires a few extra steps to check the forum as compared to email.
I am guessing that you use Google groups directly via e-mail instead of signing into the site in which case I can understand why you prefer that approach. If you could explain how to set this up then I could probably live with that.

melvin wrote:The plan is that the forum is for users and the mailing list is for development discussions, where we want to keep a permanent record of what was discussed and decided upon.
But the forum is the shop window for Magarena and at the moment it is covered in dust and grime and appears a bit neglected. A more active forum will attract more potential players, developers, scripters, feedback, etc.

Ultimately, I am not trying to step on anyones toes. I just would like the choice is all.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Development thread

Postby melvin » 22 May 2014, 07:52

Lodici wrote:Sorry melvin, I don't buy that as a compelling reason for solely using Google.
I'm only talking about the mailing list. I'm not that fond of Google Code and neither is Google at the moment, seems that it has been left to fallow.

melvin wrote:I am guessing that you use Google groups directly via e-mail instead of signing into the site in which case I can understand why you prefer that approach. If you could explain how to set this up then I could probably live with that.
Yes, I do. You can subscribe by sending email to magarena+subscribe@googlegroups.com and then confirming your email in the subscribe email they sent you.

Ultimately, I am not trying to step on anyones toes. I just would like the choice is all.
I hope you can give the mailing list another try, it doesn't need a google account, just any email address will do.
User avatar
melvin
AI Programmer
 
Posts: 1057
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 456 times

Re: Development thread

Postby melvin » 22 May 2014, 07:57

Lodici wrote:My proposal is to remove this code so that it makes things simpler and to give someone a clear run in the future should they want to implement a more comprehensive multiple image system.
Agree with this, the current method should be revamped.
User avatar
melvin
AI Programmer
 
Posts: 1057
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 456 times

Re: Development thread

Postby ShawnieBoy » 22 May 2014, 11:42

Lodici wrote:But the forum is the shop window for Magarena and at the moment it is covered in dust and grime and appears a bit neglected. A more active forum will attract more potential players, developers, scripters, feedback, etc.
I agree with Lodici on this - Using Google groups is handy, but it kinda makes it look as though we're not visiting/commenting/doing anything until a monthly info-dump on release.

melvin wrote:I can't change the forum structure, only the posts. We need either the site admin or forum admin to do that.
Oh, I assumed you had admin rights - Just a thread like the Magarena Themes - Who set that one up?
User avatar
ShawnieBoy
Programmer
 
Posts: 601
Joined: 02 Apr 2012, 22:42
Location: UK
Has thanked: 80 times
Been thanked: 50 times

Re: Development thread

Postby Lodici » 22 May 2014, 12:28

I have sent a PM to @Goblin Hero asking for authorization to create sub-forums for @melvin, @shawnieboy or @myself or to create a "Development" sub-forum himself.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Development thread

Postby Huggybaby » 22 May 2014, 15:17

Forum made and topic moved. If that's not what you wanted let me know.
User avatar
Huggybaby
Administrator
 
Posts: 3089
Joined: 15 Jan 2006, 19:44
Location: Finally out of Atlanta
Has thanked: 588 times
Been thanked: 574 times

Re: Development thread

Postby Lodici » 22 May 2014, 15:30

Huggybaby wrote:Forum made and topic moved. If that's not what you wanted let me know.
Perfect. Thanks.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Next

Return to Development

Who is online

Users browsing this forum: No registered users and 1 guest


Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 10 minutes)
Most users ever online was 427 on 11 Nov 2019, 13:00

Users browsing this forum: No registered users and 1 guest

Login Form