Magic Origins
Moderators: North, BetaSteward, noxx, jeffwadsworth, JayDi, TheElk801, LevelX, CCGHQ Admins
17 posts
• Page 1 of 2 • 1, 2
Magic Origins
by emerald000 » 15 Jun 2015, 20:40
Post which cards you are working on implementing.
I'll be working on green cards.
I'll be working on green cards.
-
emerald000 - Posts: 92
- Joined: 07 Jul 2014, 16:55
- Has thanked: 1 time
- Been thanked: 9 times
Re: Magic Origins
by emerald000 » 16 Jun 2015, 05:23
I am not sure how to properly return the new Nissa as a planeswalker. I tried using the same technique as Loyal Cathar to set it transformed after putting the card on the battlefield, but that doesn't work. The EtB ability of the front face triggers and the loyalty counters aren't being put.
I guess it will need an overhaul of the putOntoBattlefield method which I am not really comfortable doing. Should I push the semi-working version of it so you could test a fix?
No clue how to do Joraga Invocation either. It doesn't seem possible to make the rule-modifying effect with the current implementation of RequirementEffect.
I guess it will need an overhaul of the putOntoBattlefield method which I am not really comfortable doing. Should I push the semi-working version of it so you could test a fix?
No clue how to do Joraga Invocation either. It doesn't seem possible to make the rule-modifying effect with the current implementation of RequirementEffect.
-
emerald000 - Posts: 92
- Joined: 07 Jul 2014, 16:55
- Has thanked: 1 time
- Been thanked: 9 times
Re: Magic Origins
by LevelX » 16 Jun 2015, 07:15
Sure, It's anyway on my list to check this.emerald000 wrote:I am not sure how to properly return the new Nissa as a planeswalker. I tried using the same technique as Loyal Cathar to set it transformed after putting the card on the battlefield, but that doesn't work. The EtB ability of the front face triggers and the loyalty counters aren't being put.
I guess it will need an overhaul of the putOntoBattlefield method which I am not really comfortable doing. Should I push the semi-working version of it so you could test a fix?
What's the reason you can't use a normal RequirementEffect effect?emerald000 wrote:No clue how to do Joraga Invocation either. It doesn't seem possible to make the rule-modifying effect with the current implementation of RequirementEffect.
-
LevelX - DEVELOPER
- Posts: 1677
- Joined: 08 Dec 2011, 15:08
- Has thanked: 174 times
- Been thanked: 374 times
Re: Magic Origins
by emerald000 » 16 Jun 2015, 07:30
Unless I misunderstood RequirementEffect (not impossible since the names of the methods are far from optimal), it seems like there is no way to force your whole team to be blocked if able; I can only see how to do it for a single creature. You can't create a bunch of effects for each creature either as it applies also to creatures entering the battlefield after the spell resolves.LevelX wrote:What's the reason you can't use a normal RequirementEffect effect?emerald000 wrote:No clue how to do Joraga Invocation either. It doesn't seem possible to make the rule-modifying effect with the current implementation of RequirementEffect.
-
emerald000 - Posts: 92
- Joined: 07 Jul 2014, 16:55
- Has thanked: 1 time
- Been thanked: 9 times
Re: Magic Origins
by LevelX » 16 Jun 2015, 10:16
I guess you need only one requirement effect that returns true for mustBlock() and have to check in the applies() method if the controller of the effect is the active player (so he is the only player that can attack).emerald000 wrote:Unless I misunderstood RequirementEffect (not impossible since the names of the methods are far from optimal), it seems like there is no way to force your whole team to be blocked if able; I can only see how to do it for a single creature. You can't create a bunch of effects for each creature either as it applies also to creatures entering the battlefield after the spell resolves.LevelX wrote:What's the reason you can't use a normal RequirementEffect effect?emerald000 wrote:No clue how to do Joraga Invocation either. It doesn't seem possible to make the rule-modifying effect with the current implementation of RequirementEffect.
So all permanents that are creatures of an opponent (in range of the controller) have to block => so the applies() method of this reqirement effect has to return true.
-
LevelX - DEVELOPER
- Posts: 1677
- Joined: 08 Dec 2011, 15:08
- Has thanked: 174 times
- Been thanked: 374 times
Re: Magic Origins
by emerald000 » 16 Jun 2015, 18:26
That's not how the card works though. You have to block all creatures, not all creatures have to block. If you have more defenders than attackers, you will be able to leave some creatures back. Also, you can't gang-block a creature if that leaves another creature unblocked, since you could satisfy that requirement.LevelX wrote:I guess you need only one requirement effect that returns true for mustBlock() and have to check in the applies() method if the controller of the effect is the active player (so he is the only player that can attack).emerald000 wrote:Unless I misunderstood RequirementEffect (not impossible since the names of the methods are far from optimal), it seems like there is no way to force your whole team to be blocked if able; I can only see how to do it for a single creature. You can't create a bunch of effects for each creature either as it applies also to creatures entering the battlefield after the spell resolves.
So all permanents that are creatures of an opponent (in range of the controller) have to block => so the applies() method of this reqirement effect has to return true.
-
emerald000 - Posts: 92
- Joined: 07 Jul 2014, 16:55
- Has thanked: 1 time
- Been thanked: 9 times
Re: Magic Origins
by LevelX » 16 Jun 2015, 22:08
You're right, the the mustBlock() has to return false, but the mustBlockAttackerIfElseUnblocked() method has to return true.emerald000 wrote:That's not how the card works though. You have to block all creatures, not all creatures have to block. If you have more defenders than attackers, you will be able to leave some creatures back. Also, you can't gang-block a creature if that leaves another creature unblocked, since you could satisfy that requirement.LevelX wrote:I guess you need only one requirement effect that returns true for mustBlock() and have to check in the applies() method if the controller of the effect is the active player (so he is the only player that can attack).emerald000 wrote:Unless I misunderstood RequirementEffect (not impossible since the names of the methods are far from optimal), it seems like there is no way to force your whole team to be blocked if able; I can only see how to do it for a single creature. You can't create a bunch of effects for each creature either as it applies also to creatures entering the battlefield after the spell resolves.
So all permanents that are creatures of an opponent (in range of the controller) have to block => so the applies() method of this reqirement effect has to return true.
Look at the MustBeBlockedByAtLeastOneTargetEffect class as example and apply it to all opponent creatures of the controller of Joraga Invocation.
The check which block is legal or violates the least possible number of requirements has to be done from the combat logic (which can probably be improved, but that's another story).
-
LevelX - DEVELOPER
- Posts: 1677
- Joined: 08 Dec 2011, 15:08
- Has thanked: 174 times
- Been thanked: 374 times
Re: Magic Origins
by tself55 » 20 Jun 2015, 22:20
Hixus, Prison Warden is currently a 4/44 instead of the correct stats 4/4 in the collection viewer.
Re: Magic Origins
by LevelX » 20 Jun 2015, 23:35
Hard to kill by damage.tself55 wrote:Hixus, Prison Warden is currently a 4/44 instead of the correct stats 4/4 in the collection viewer.
It's fixed now, thanks for the hint.
-
LevelX - DEVELOPER
- Posts: 1677
- Joined: 08 Dec 2011, 15:08
- Has thanked: 174 times
- Been thanked: 374 times
Re: Magic Origins
by fireshoes » 23 Jun 2015, 01:22
Last edited by fireshoes on 03 Jul 2015, 04:04, edited 26 times in total.
Re: Magic Origins
by LevelX » 04 Jul 2015, 09:06
All missing cards 2015-07-04 22:30 CET
WHITE
- Complete
BLUE
- Complete
BLACK
- Complete
RED
- Complete
GREEN
- Complete
MULTI
- Complete
ARTIFACTS
- Complete
LANDS
- Complete
WHITE
- Complete
BLUE
- Complete
BLACK
- Complete
RED
- Complete
GREEN
- Complete
MULTI
- Complete
ARTIFACTS
- Complete
LANDS
- Complete
-
LevelX - DEVELOPER
- Posts: 1677
- Joined: 08 Dec 2011, 15:08
- Has thanked: 174 times
- Been thanked: 374 times
Re: Magic Origins
by LoneFox » 04 Jul 2015, 15:55
I have added some artifacts and black cards to my fork of the git repository.
Re: Magic Origins
by Julia » 04 Jul 2015, 18:34
I submitted a pull request containing Acolyte of the Inferno, Ghirapur AEther Grid, Mage-Ring Bully, Prickleboar and Thopter Engineer.
*edit: Ampryn Tactician, Aven Battle Priest, Enlightened Ascetic and Healing Hands have also been implemented, and submitted through a second pull request.
*edit: Ampryn Tactician, Aven Battle Priest, Enlightened Ascetic and Healing Hands have also been implemented, and submitted through a second pull request.
Re: Magic Origins
by LevelX » 04 Jul 2015, 20:31
- DONE | Open
- 215|Possessed Skaab
218|Thunderclap Wyvern
52|Deep-Sea Terror
58|Harbinger of the Tides
66|Nivix Barrier
67|Psychic Rebuttal
43|Alhammarret, High Arbiter
44|Anchor to the AEther
48|Calculated Dismissal
34|Suppression Bonds
35|Swift Reckoning
38|Tragic Arrogance
121|Thornbow Archer
123|Touch of Moonglove
89|Dark Dabbling
111|Nightsnare
118|Shadows of the Past
236|Pyromancer's Goggles
239|Sigil of Valor
234|Orbs of Warding
235|Prism Ring
16|Hallowed Moonlight
25|Kytheon's Tactics
11|Consul's Lieutenant
4|Archangel of Tithes
Working on:
-
LevelX - DEVELOPER
- Posts: 1677
- Joined: 08 Dec 2011, 15:08
- Has thanked: 174 times
- Been thanked: 374 times
Re: Magic Origins
by LoneFox » 05 Jul 2015, 07:10
Foundry of the Consuls and Mage-Ring Network are implemented in my repository. I also finally got Grab the Reins working properly, it needed tha same fix as Wild Instincts.
Edit: Added Call of the Full Moon, Embermaw Hellion, Sword of the Animist, and Throwing Knife.
LevelX: Updated the list
Edit: Added Call of the Full Moon, Embermaw Hellion, Sword of the Animist, and Throwing Knife.
LevelX: Updated the list
17 posts
• Page 1 of 2 • 1, 2
Who is online
Users browsing this forum: No registered users and 3 guests