It is currently 17 Sep 2019, 16:30
   
Text Size

Add a new/missing set to the XMage project

Moderators: TheElk801, BetaSteward, LevelX, North, noxx, JayDi, jeffwadsworth, CCGHQ Admins

Add a new/missing set to the XMage project

Postby LevelX » 20 Dec 2014, 17:12

Add the new set to the files in MAGE/Utils for the Perl utility scripts
Utils/known-sets.txt
* Add the set
Utils/mtg-sets-data.txt
* Add the set
Utils/mtg-cards-data.txt
* Add card data from Gatherer crawler file (if already available)
Project: Mage Sets
* Create the set object itself under mage.sets
* Create a new java package name: mage.sets.<set name>

Token / Images / Download
client/src/main/resources/image.url.properties
* Add ignore url to ignore download as long no pictures are provided
* Add set abbr. to token lookup order
client/src/main/resources/card-pictures-tok.txt
* Add new token images to the list

Add the set to the following classes
mage.client.util.sets.ConstructedFormats.java (2 places)
client/src/main/java/org/mage/plugins/card/dl/sources/GathererSets.java
client/src/main/java/org/mage/plugins/card/dl/sources/MagicCardsImageSource.java
client/src/main/java/org/mage/plugins/card/dl/sources/WizardCardsImageSource.java

Check if the new set will be included correctly to the format checks
User avatar
LevelX
DEVELOPER
 
Posts: 1677
Joined: 08 Dec 2011, 15:08
Has thanked: 174 times
Been thanked: 374 times

Re: Add a new/missing set to the XMage project

Postby escplan9 » 15 Apr 2016, 11:50

Since this post is slightly outdated, I recently added the set "Welcome Deck 2016"

As far as I can tell, and what LevelX said, this section "mage.client.util.sets.ConstructedFormats.java (2 places)" is no longer relevant. ConstructedFormats.java determines the legality of each format dynamically now.

The remainder of the steps still need to be done.

Also, since it was not mentioned here, there are a couple other steps:

* Add a class for the set in Mage.Sets ("WelcomeDeck2016.java") and set its properties (see other sets for examples)
* Add a package for the set in Mage.Sets (mage.sets.welcomedeck2016)
* Run the Utils/gen-existings-cards-by-set.pl on the set if there are pre-existing cards to generate some of them for you.

Still cannot find out why the set is not considered "standard legal" though in the Deck Builder. Don't know if this set is some unusual exception to previous supplemental ones? Or if this is something different entirely. Promotional set?

Commit here:
Code: Select all
https://github.com/magefree/mage/commit/e136e409fd445272c3ff48a4531b1911a8d62211
escplan9
 
Posts: 257
Joined: 10 Aug 2015, 22:38
Has thanked: 26 times
Been thanked: 39 times

Re: Add a new/missing set to the XMage project

Postby LevelX » 15 Apr 2016, 15:43

escplan9 wrote:* Add a class for the set in Mage.Sets ("WelcomeDeck2016.java") and set its properties (see other sets for examples)
* Add a package for the set in Mage.Sets (mage.sets.welcomedeck2016)
These actions are already in the basic list.
User avatar
LevelX
DEVELOPER
 
Posts: 1677
Joined: 08 Dec 2011, 15:08
Has thanked: 174 times
Been thanked: 374 times

Re: Add a new/missing set to the XMage project

Postby escplan9 » 15 Apr 2016, 16:26

You're right, I must have glossed over that part. Anyways, got W16 working correctly in the latest commit. Thanks.
escplan9
 
Posts: 257
Joined: 10 Aug 2015, 22:38
Has thanked: 26 times
Been thanked: 39 times


Return to Developers Talk

Who is online

Users browsing this forum: No registered users and 1 guest


Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 10 minutes)
Most users ever online was 287 on 31 Mar 2019, 04:11

Users browsing this forum: No registered users and 1 guest

Login Form