Collectible Card Game Headquarters

So I'm done coding Scuttlemutt, which required a new BecomesColorOrColorsTargetEffect class in mage-abilities-effects-common-continious (during this process I noted that the current effect called by Swirling Spriggan does not work as intended but I didn't want to go fiddling with someone else's code).
I'm very excited to contribute but I'm not quite sure how to do so from NetBeans. I cloned the repository in NetBeans and have committed my changes. Now do I root>git>remote>push or am I missing some steps?

Yes with the push you transfer your commits to the forked remote repository.

ok, I've got it pushed to my fork and added pull request.

Yes of course.
I never do it myself so I'm missing the practice.

LevelX, I believe you coded Swirling Spriggan. The ChangeColorOrColorsTargetEffect you used calls BecomesColorTargetEffect but that just keeps overwriting the previously selected color when you loop through it. I believe you can instead call the BecomesColorOrColorsTargetEffect I just uploaded to make Spriggan's ability work properly. No for loop required though, just pass the chosenColors list directly to the effect.

philvt101 wrote:LevelX, I believe you coded Swirling Spriggan. The ChangeColorOrColorsTargetEffect you used calls BecomesColorTargetEffect but that just keeps overwriting the previously selected color when you loop through it. I believe you can instead call the BecomesColorOrColorsTargetEffect I just uploaded to make Spriggan's ability work properly. No for loop required though, just pass the chosenColors list directly to the effect.

You're right I guess.
If you like you can fix it and add to the pull request.
Thanks for pointing out.

I'm happy to have made my first contribution to mage and it's nice that my ability code could be applied to a handful of cards.
Next time I'll be a little more thorough before my pull request.

Hi guys,

I implemented a simple card, Wrecking Ball, from DIS and CMD. I don't know how to send my files back. I did a git -> commit... and it appears to work. I can't do a git -> remote -> push... It asks for a username/password.

I don't know if the file was sent, or what is the correct procedure to send the file for consideration.

I cloned the repository as specified at the Developer Getting Started document.

JotaPeRL wrote:Hi guys,

I implemented a simple card, Wrecking Ball, from DIS and CMD. I don't know how to send my files back. I did a git -> commit... and it appears to work. I can't do a git -> remote -> push... It asks for a username/password.

I don't know if the file was sent, or what is the correct procedure to send the file for consideration.

I cloned the repository as specified at the Developer Getting Started document.

You have to do a "Pull Request" with your changes to the main repository.
Currently no such request is available to merge yet.
So you missed something.