DomainValue()

[LokiX]

Hi,
I'm trying to implement Allied Strategies, however that card needs the domain count of the target player not of the controller, XMage DomainValue() currently doesn't support this, and so I thought of adding another method 'calculate' to the existing DomainValue class which would be something like this

Code: Select all

public int calculate(Game game, Player target, Effect effect)

But I'm not sure that's the right approach. Should I do it like I described it, or should I create a class TargetDomainValue that would calculate the the domain value of the target and if so, should I just extend DomainValue class and Override the calculate method?

Or do you guys have any other suggestion that I might be missing?

[LevelX]

A new calculate method is no good idea. It wouldn't be compatible with the existing classes that use DynamicValues.

I would simply add a new boolean parameter to the DomainValue() class.

So the constructors would look like this.

Code: Select all

    public DomainValue() {
        this(1);
    }

    public DomainValue(boolean countTargetPlayer){
        this(1, countTargetPlayer);
    }

    public DomainValue(Integer amount){
        this(amount, false);
    }

    public DomainValue(Integer amount, boolean countTargetPlayer){
        this.amount = amount;
    }

And than add the other needed logic to support the parameter in the class.

[LokiX]

Thanks, LevelX.
I had to modify it a bit for it to work but I think I got the general idea.

Will make a PR in a bit.

Thanks, again.