As long as <card name> is untapped (or tapped) question

[MTGfan]

In looking at code to figure out how to code another card I encountered a few cards with as long as <card name> is untapped that don't use

Code: Select all

new SimpleStaticAbility(Zone, new ConditionalContinuousEffect(Effect, [b]new InvertCondition(new SourceTappedCondition()[/b])), String);

They are Archangel of Tithes, Static Orb, Storage Matrix, Thunderstaff. Should they be using this? If not I'd like to understand why they don't compared to other cards with same phrasing.

And I encountered a few cards with as long as <card name is tapped that done use

Code: Select all

new SimpleActivatedAbility(Zone, new ConditionalContinuousEffect(Effect, SourceTappedCondition.getInstance()), String);

They are Archangel of Tithes, Centaur Omenreader, Hisoka's Guard, Thran Weaponry. Should they be using this? If not I'd like to understand why they don't compared to other cards with same phrasing.


And I encountered Helm of Possession that doesn't use SourceTappedCondition.getInstance(). I believe by using CompoundCondition(String, Controller is equal to owner, SourceTappedCondition.getInstance()) rather than the custom class it is using to define the two conditions as long as you control and is tapped.

Let me know ya'll thoughts. Thanks.

EDIT: Please move to developer section as I meant to post this there.