Wardscale Dragon and Xantid Swarm
Moderators: North, BetaSteward, noxx, jeffwadsworth, JayDi, TheElk801, LevelX, CCGHQ Admins
Wardscale Dragon and Xantid Swarm
by MTGfan » 27 Nov 2016, 01:10
Should Wardscale Dragon be edited to use ConditionalContinuousEffect? Or is the way it is coded the better way to handle it. Functionally I believe it would be the same the difference would be in what code is executed. But I could be wrong. Basically the card's code would change with the ability line being:
However Xantid Swarm code doesn't use AttacksTriggeredAbility it appears to me to be redundantly doing it with class XantidSwarmTriggeredAbility. So my guess is that it should be for sure changed to at the ability line from:
- Code: Select all
this.addAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new ConditionalContinuousEffect(<effect>, SourceAttackingCondition.getInstance(), "As long as {this} is attacking, defending player can't cast spells")));
- Code: Select all
public boolean applies(GameEvent event, Ability source, Game game) {
Permanent sourcePermanent = game.getPermanent(source.getSourceId());
if (sourcePermanent != null && sourcePermanent.isAttacking()) {
return event.getPlayerId().equals(game.getCombat().getDefendingPlayerId(sourcePermanent.getId(), game));
}
return false;
}
- Code: Select all
public boolean applies(GameEvent event, Ability source, Game game) {
return event.getPlayerId().equals(game.getCombat().getDefendingPlayerId(sourcePermanent.getId(), game));
}
However Xantid Swarm code doesn't use AttacksTriggeredAbility it appears to me to be redundantly doing it with class XantidSwarmTriggeredAbility. So my guess is that it should be for sure changed to at the ability line from:
- Code: Select all
Ability ability = new XantidSwarmTriggeredAbility(new XantidSwarmReplacementEffect());
this.addAbility(ability);
- Code: Select all
this.addAbility(new AttacksTriggeredAbility(new XantidSwarmReplacementEffect(), false));
1 post
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 4 guests