Page 1 of 3

Testing the combat system

PostPosted: 07 Jun 2008, 15:20
by Incantus
I think Incantus can handle most complicated combat restrictions and requirements (see rule 500.4 - http://yawgatog.com/resources/magic-rules/#R500.4). However, it's impossible to know without testing a few weird situations. So it would be cool if people could post some examples (as long as none involve blocking more than one creature - Incantus can't handle that yet).

Re: Testing the combat system

PostPosted: 07 Jun 2008, 19:32
by Huggybaby
I haven't made the new version break yet, seems very stable. :)

Re: Testing the combat system

PostPosted: 07 Jun 2008, 20:47
by cort
Just had another crash after using Rampant Growth, after i click on the land in my library and hit Enter - probably due to the fact that the land card enters the game allready tapped.
I have attached the crashlog and replay.

Re: Testing the combat system

PostPosted: 07 Jun 2008, 21:28
by cort
I managed to replicate the crash that occurs when using Blaze. It's a long replay because it took some time to get it into play.

Re: Testing the combat system

PostPosted: 07 Jun 2008, 22:12
by Incantus
cort wrote:... probably due to the fact that the land card enters the game allready tapped.
Yeah, currently all enters into play replacement effects are broken. Hope to fix that next (they used to work until I implemented ordering cards that come into play at the same time).

Re: Testing the combat system

PostPosted: 08 Jun 2008, 20:35
by cort
Got another crash when trying to put into play Cho-Manno, Revolutionary while Ascendant Evincar was into play. Probably a conflict between 'Prevent all damage' and 'Nonblack creatures get -1/-1'.

Re: Testing the combat system

PostPosted: 08 Jun 2008, 22:07
by Incantus
Thanks for catching this. It was a bug with cards that have replacement effects. I've put a new version up on the stickied download page.

Re: Testing the combat system

PostPosted: 09 Jun 2008, 09:58
by staggerwingjtstw
I got a crash when I played a Hurricane for x=8 and my opponent's life was 8, giving me a win.

I got a second crash going from upkeep to draw. I'm not sure what caused it. I was trying out a deck that has some more unique abilities and keywords.

[Edit} Ok, I've re-uploaded the rar to include the game replay file :)

Re: Testing the combat system

PostPosted: 09 Jun 2008, 10:46
by The Scientist
try to include the game.replay file.
For example, it would help for the second crash to see what cards in play were at the time of the crash.

Re: Testing the combat system

PostPosted: 11 Jun 2008, 19:24
by cort
Software crashes after clicking on Condemn when there are no creatures into play.

Also, I have one minor request. Could you aplly an offset to the opponent's cards, because when using right click on the leftmost card 1/5 of the card is not visible (like in attached picture).

Re: Testing the combat system

PostPosted: 11 Jun 2008, 23:14
by Huggybaby
Does moving the playfield or zooming out fix it?

Re: Testing the combat system

PostPosted: 12 Jun 2008, 06:53
by The Scientist
nope that doesn't. the zooming for the cards just makes the card bigger beneath the original card, so he just needs to move it for the left card.

And the error with condemn is "AttributeError: 'NoneType' object has no attribute 'toughness'"
I guess there is a bug with it.
When you try to play terror with no creatures in play, it won't allow you, because nothing of the target "isCreature" can be found.
however, in condemn's case, it has to find "isCreature.with_condition ..." and for some reason I guess it tries to find something with that condition which isn't relevant if there's no creature in the first place.

Incantus ?

Re: Testing the combat system

PostPosted: 12 Jun 2008, 15:32
by Incantus
OK, fixed.

(Scientist - also fixed the problems with the planeswalkers, and Zombifying a creature with evoke)

http://www.mediafire.com/?ooczmyp0kmh

Re: Testing the combat system

PostPosted: 12 Jun 2008, 20:45
by MageKing17
Let me start by saying what an amazing program you have here so far.

Secondly, just got a crash killing the 10e_red deck with the 10e_black deck with a Looming Shade pumped into a 10/10 (9/9, actually, but I had Ascendant Evincar out). Error was "ValueError: list.remove(x): x not in list". Replay attached for your benefit.

Re: Testing the combat system

PostPosted: 12 Jun 2008, 21:15
by Incantus
It seems these crashes are occuring at the end of the game, after the player has already won. Currently the game isn't properly reset - you have to restart the program to play a new game. I think the crash is happening when I try and reset the game.

Anybody have any negative feedback :) What would make the game better (besides more cards)?