It is currently 18 Nov 2019, 18:57
   
Text Size

Bug reports for v0.7.1c

by Incantus

Moderators: Incantus, CCGHQ Admins

Bug reports for v0.7.1c

Postby MageKing17 » 08 Feb 2009, 22:58

(Created at the suggestion of Marek14)

What I need from you when you're reporting a bug:
  • Check to see if the bug is already reported... let's not be redundant, here.
  • While you're at it, check the version the bug was reported for. If it was for v0.7.0a and you're using v0.7.1a... report it again!
  • Describe what you were doing when it happened, what card was last played/triggered/clicked on, whatever.
  • Supply a game replay (game.replay) and the traceback of the crash (incantus.exe.log). This can be done by using the "Upload Attachment" tab when you post a reply.

Don't bother reporting these known issues:
  • The inability to undo.
  • Menu fonts shrinking after having started a game
  • Phyrexian Mana not working

Now go out there, have fun, and report some bugs! :)
Last edited by MageKing17 on 28 May 2012, 20:43, edited 12 times in total.
User avatar
MageKing17
Programmer
 
Posts: 473
Joined: 12 Jun 2008, 20:40
Has thanked: 5 times
Been thanked: 9 times

Re: Bug reports for v0.57

Postby Huggybaby » 09 Feb 2009, 15:08

Good topic. Stickied.
User avatar
Huggybaby
Administrator
 
Posts: 3089
Joined: 15 Jan 2006, 19:44
Location: Finally out of Atlanta
Has thanked: 588 times
Been thanked: 574 times

Re: Bug reports for v0.57

Postby MageKing17 » 09 Feb 2009, 22:56

Self-report so we don't get a redundant report:

Basalt Monolith, among others (cards using doesntUntapAbility()), is broken, generated an "'override_effect' is not defined" error. This will be fixed in the next version.
User avatar
MageKing17
Programmer
 
Posts: 473
Joined: 12 Jun 2008, 20:40
Has thanked: 5 times
Been thanked: 9 times

Re: Bug reports for v0.57

Postby juzamjedi » 10 Feb 2009, 07:43

Turn to Mist has a non-fatal bug (no traceback). If played during the End of Turn phase it will remove the creature from the game, but the creature never returns to the game. The effect should be pushed onto next player's end of turn phase and resolve at beginning of next end of turn. See rule 313.2
juzamjedi
Tester
 
Posts: 575
Joined: 13 Nov 2008, 08:35
Has thanked: 6 times
Been thanked: 8 times

Re: Bug reports for v0.57

Postby MageKing17 » 11 Feb 2009, 01:09

juzamjedi wrote:Turn to Mist has a non-fatal bug (no traceback). If played during the End of Turn phase it will remove the creature from the game, but the creature never returns to the game. The effect should be pushed onto next player's end of turn phase and resolve at beginning of next end of turn. See rule 313.2
The card was probably coded to make the delayed trigger expire at the end of the turn... obviously a bad thing if you play it during the End of Turn step. I'll make it expire later.

Keep an eye out for similar cards that may have the same problem (delayed trigger that triggers at the End of Turn step).

EDIT: I was wrong, the ability has no duration... that's probably the problem, nothing is storing a reference to it, so it gets garbage collected. I'll try giving it a duration and see if that works.
User avatar
MageKing17
Programmer
 
Posts: 473
Joined: 12 Jun 2008, 20:40
Has thanked: 5 times
Been thanked: 9 times

Re: Bug reports for v0.57

Postby Incantus » 11 Feb 2009, 04:12

MageKing - Marek had wrapped it in an until_end_of_turn, which I removed. He also put it back into play under the control of the ability's controller, instead of the owner.
Incantus
DEVELOPER
 
Posts: 267
Joined: 29 May 2008, 15:53
Has thanked: 0 time
Been thanked: 3 times

Re: Bug reports for v0.57

Postby juzamjedi » 11 Feb 2009, 05:46

Playing Mox Diamond causes this fatal crash. Note that this crash happens regardless whether I have a land I can discard or not.

Code: Select all
Traceback (most recent call last):
  File "main.py", line 7, in <module>
  File "ui\Incantus.pyo", line 790, in main
  File "ui\Incantus.pyo", line 656, in run
  File "game\GameKeeper.pyo", line 98, in start
  File "game\GameKeeper.pyo", line 118, in run
  File "game\GameKeeper.pyo", line 251, in mainPhase1
  File "game\GameKeeper.pyo", line 396, in playSpells
  File "game\Stack.pyo", line 40, in resolve
  File "game\Ability\Ability.pyo", line 44, in resolve
  File "game\Ability\CastingAbility.pyo", line 32, in resolved
  File "game\stacked_function.pyo", line 131, in __call__
  File "<string>", line 19, in move_to
NameError: global name 'controller' is not defined
juzamjedi
Tester
 
Posts: 575
Joined: 13 Nov 2008, 08:35
Has thanked: 6 times
Been thanked: 8 times

Re: Bug reports for v0.57

Postby juzamjedi » 11 Feb 2009, 06:11

When I tap Gemstone Mine for mana it causes this crash:

Code: Select all
Traceback (most recent call last):
  File "main.py", line 7, in <module>
  File "ui\Incantus.pyo", line 790, in main
  File "ui\Incantus.pyo", line 656, in run
  File "game\GameKeeper.pyo", line 98, in start
  File "game\GameKeeper.pyo", line 118, in run
  File "game\GameKeeper.pyo", line 251, in mainPhase1
  File "game\GameKeeper.pyo", line 398, in playSpells
  File "game\GameKeeper.pyo", line 409, in playStackSpells
  File "game\Action.pyo", line 96, in perform
  File "game\Ability\Ability.pyo", line 15, in announce
  File "game\Ability\ActivatedAbility.pyo", line 61, in played
  File "game\Ability\Ability.pyo", line 42, in resolve
  File "<string>", line 29, in effects
TypeError: 'list' object is not callable
juzamjedi
Tester
 
Posts: 575
Joined: 13 Nov 2008, 08:35
Has thanked: 6 times
Been thanked: 8 times

Re: Bug reports for v0.57

Postby The Scientist » 11 Feb 2009, 08:55

ok, fixed both errors, I think.
Mox Diamond has a replacement effect which references the Mox, but not the player playing the mox, so I fixed it, and I also added a prompt, since you can choose not to discard a land card.
Note that regardless of the choice, the game looks at wether you will actually discard a land card to see if it gets to be in play or not.

Gemstone mine has to check the number of counters on it, and the current version used the wrong code, I think I fixed it, but I can't test it until later.

MK : perhaps you can upload a new cards.db so people can test changes made to cards ?

oh, and thanks juzamjedi for reporting this. Some cards aren't changed when the syntax of coding is adjusted. Some cards are just untested. Feel free to test more cards !
The Scientist
 
Posts: 94
Joined: 05 Jun 2008, 07:39
Has thanked: 0 time
Been thanked: 0 time

Re: Bug reports for v0.57

Postby MageKing17 » 11 Feb 2009, 09:16

The Scientist wrote:MK : perhaps you can upload a new cards.db so people can test changes made to cards ?
Actually, while I was testing some of the cards you uploaded (Rhys the Redeemed, for instance), I found that Clash was broken and fixed it. So a new version entirely is in order (v0.571, perhaps).
User avatar
MageKing17
Programmer
 
Posts: 473
Joined: 12 Jun 2008, 20:40
Has thanked: 5 times
Been thanked: 9 times

Re: Bug reports for v0.571

Postby The Scientist » 11 Feb 2009, 23:04

will try to retest clash.

Also broken : Changeling
The Scientist
 
Posts: 94
Joined: 05 Jun 2008, 07:39
Has thanked: 0 time
Been thanked: 0 time

Re: Bug reports for v0.571

Postby MageKing17 » 12 Feb 2009, 05:38

Already fixed, TheScient. It was an import error in LorwynAbility.
User avatar
MageKing17
Programmer
 
Posts: 473
Joined: 12 Jun 2008, 20:40
Has thanked: 5 times
Been thanked: 9 times

Re: Bug reports for v0.571

Postby The Scientist » 12 Feb 2009, 12:40

I'd like to see evoke working, don't know if that's possible ?
The Scientist
 
Posts: 94
Joined: 05 Jun 2008, 07:39
Has thanked: 0 time
Been thanked: 0 time

Re: Bug reports for v0.571

Postby MageKing17 » 12 Feb 2009, 17:47

The Scientist wrote:I'd like to see evoke working, don't know if that's possible ?
As far as I'm concerned, it falls under "additional playing methods", and so will need to wait for the upgraded framework. That doesn't mean it's not theoretically possible to hack something together before then, just that I won't be the one doing the hacking. :P
User avatar
MageKing17
Programmer
 
Posts: 473
Joined: 12 Jun 2008, 20:40
Has thanked: 5 times
Been thanked: 9 times

Re: Bug reports for v0.571

Postby Helza » 13 Feb 2009, 19:17

Ok, did some testing today, here is the result :P

Conflux cards that tested ok:
Ember Weaver
Drag Down
Celestial Purge
Aven Trailblazer
Darklit Gargoyle
Corrupted Roots
Asha's Favor
Blood Tyrant
Cumber Stone
Constricting Tendrils
Absorb Vis


Some problems i encountered:

Elder Mastery
Probably general problem with other Keyword gains aswell.
Played it on Blood Tyrant, which now had 2x Flying in list


Charnelhoard Wurm
Trample didn't seem to work?
Charnelhoard Wurm was 3/6 (because of Constricting Tendrils)
2x Cumber Stone in play

Blocked by:
Dread Wings 0/1 (Bone Saw)
Dread Wings -1/1

I assigned 2 damage to 1 (first one i think) of them,
and 1 damage to the other, trample never happened and i never got to return a card from graveyard :(



Bone Saw
Card remained lying in the middle of the field after attached created died, didnt move back to neutral place)

Crash #1 (fixed by TheScient)
Traceback (most recent call last):
File "main.py", line 7, in <module>
File "ui\Incantus.pyo", line 790, in main
File "ui\Incantus.pyo", line 656, in run
File "game\GameKeeper.pyo", line 98, in start
File "game\GameKeeper.pyo", line 118, in run
File "game\GameKeeper.pyo", line 251, in mainPhase1
File "game\GameKeeper.pyo", line 398, in playSpells
File "game\GameKeeper.pyo", line 409, in playStackSpells
File "game\Action.pyo", line 96, in perform
File "game\Ability\Ability.pyo", line 14, in announce
File "game\Ability\ActivatedAbility.pyo", line 21, in do_announce
AttributeError: 'int' object has no attribute 'precompute'


Crash #2 when Activated Bone Saw ability, while it wanted to assign it to my only create i clicked that creature, and tapped a land, all while the animation was occuring
Traceback (most recent call last):
File "main.py", line 7, in <module>
File "ui\Incantus.pyo", line 790, in main
File "ui\Incantus.pyo", line 656, in run
File "game\GameKeeper.pyo", line 98, in start
File "game\GameKeeper.pyo", line 118, in run
File "game\GameKeeper.pyo", line 251, in mainPhase1
File "game\GameKeeper.pyo", line 396, in playSpells
File "game\Stack.pyo", line 40, in resolve
File "game\Ability\Ability.pyo", line 40, in resolve
File "game\Ability\PermanentAbility.pyo", line 23, in effects
File "game\CardRoles.pyo", line 455, in attach
File "game\GameObjects.pyo", line 15, in send
File "game\pydispatch\dispatcher.pyo", line 392, in send
File "game\pydispatch\robustapply.pyo", line 47, in robustApply
File "ui\play_view.pyo", line 256, in card_attached
ValueError: list.remove(x): x not in list


Armillary Sphere
Crash, probable UI scroll bug, card worked earlier, scrolled extremely to right

Traceback (most recent call last):
File "\loewis\25\python\Modules\_ctypes\callbacks.c", line 206, in 'calling callback function'
File "pyglet\window\win32\__init__.pyo", line 849, in _wnd_proc
File "pyglet\window\win32\__init__.pyo", line 995, in _event_mousemove
File "pyglet\window\__init__.pyo", line 1217, in dispatch_event
File "pyglet\event.pyo", line 340, in dispatch_event
File "ui\controllers.pyo", line 256, in on_mouse_drag
File "ui\card_view.pyo", line 585, in layout_straight
IndexError: list index out of range
Traceback (most recent call last):
File "main.py", line 7, in <module>
File "ui\Incantus.pyo", line 790, in main
File "ui\Incantus.pyo", line 656, in run
File "game\GameKeeper.pyo", line 98, in start
File "game\GameKeeper.pyo", line 118, in run
File "game\GameKeeper.pyo", line 251, in mainPhase1
File "game\GameKeeper.pyo", line 396, in playSpells
File "game\Stack.pyo", line 40, in resolve
File "game\Ability\Ability.pyo", line 40, in resolve
File "<string>", line 21, in effects
File "game\Player.pyo", line 169, in choose_from_zone
File "game\Player.pyo", line 504, in getCardSelection
File "game\Player.pyo", line 427, in input
File "ui\Incantus.pyo", line 757, in userinput
File "ui\Incantus.pyo", line 183, in draw
File "ui\Incantus.pyo", line 236, in draw_overlay
File "ui\widget.pyo", line 56, in render
File "ui\card_view.pyo", line 676, in render_after_transform
File "ui\card_view.pyo", line 51, in fget
IndexError: list index out of range
Helza
 
Posts: 12
Joined: 14 Jan 2009, 23:54
Has thanked: 0 time
Been thanked: 0 time

Next

Return to Incantus

Who is online

Users browsing this forum: No registered users and 1 guest


Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 10 minutes)
Most users ever online was 546 on 15 Nov 2019, 10:18

Users browsing this forum: No registered users and 1 guest

Login Form