Bug reports for v0.7.1c

[MageKing17]

ask incantus, he's on linux no ?

No, he's on Mac.

And I didn't think pyglet was in the normal python distribution.

It isn't. I just said it was the one thing not in the normal distribution for Windows.

In any case, the guy who tested this knows a lot more about linux than we do

Then it would be nice if he made an account so I could talk to him directly.

[The Scientist]

he didn't want to. I'll ask him to drop by in #incantus if he has the time

[frwololo]

he didn't want to. I'll ask him to drop by in #incantus if he has the time

I had a linux user for Wagic who was complaining how non standard all my stuff was. He ended up fixing all my sh#t, which was for the greater good (except all the stuff he swore was completely standard, while it was Posix standard and wouldn't run on Windows anymore, such as dirent.h). Still, I wonder what they put in Linux that makes its users so angry at life in general. Too much cafeine in the Kernel, or something.

[juzamjedi]

Bushido keyword ability seems to be broken. I had not been testing this keyword ability, but it crashes with this error:

Code: Select all

Traceback (most recent call last):
  File "main.py", line 7, in <module>
  File "ui\Incantus.pyo", line 790, in main
  File "ui\Incantus.pyo", line 656, in run
  File "engine\GameKeeper.pyo", line 82, in start
  File "engine\GameKeeper.pyo", line 115, in run
  File "engine\GameKeeper.pyo", line 341, in combatPhase
  File "engine\GameKeeper.pyo", line 410, in playInstantaneous
  File "engine\Stack.pyo", line 40, in resolve
  File "engine\Ability\Ability.pyo", line 40, in resolve
  File "engine\Ability\KamigawaAbility.pyo", line 25, in effects
UnboundLocalError: local variable 'value' referenced before assignment


[MageKing17]

Fixed for the next release.

[juzamjedi]

Unblockable keyword ability seems to have a problem with the display text where it says "- is unblockbale". It looks like it uses the "-" character instead of the "~" character. Maybe it would make more sense to just put "Unblockable" for the display text instead

[MageKing17]

Unblockable keyword ability seems to have a problem with the display text where it says "- is unblockbale". It looks like it uses the "-" character instead of the "~" character. Maybe it would make more sense to just put "Unblockable" for the display text instead

Firstly: It 100% definitely uses the ~ character. It just looks like a "-". The reason it doesn't autoreplace is because autoreplacement is done at load-time instead of display-time (I'm definitely thinking of having this changed, so that copied abilities change names properly, but that would require going through every card and changing every instance of the card's name to "~").

Secondly: Putting just "Unblockable" is the worst possible thing to do because it reinforces the misconception that unblockable is a keyword.

[Marek14]

Or replace it with text "This creature is unblockable."

[MageKing17]

Or replace it with text "This creature is unblockable."

I don't see how that is any different from "~ is unblockable."

[Marek14]

Or replace it with text "This creature is unblockable."

I don't see how that is any different from "~ is unblockable."

It looks better than the tilde.

[juzamjedi]

If you have an empty library (no cards) and try to search your library, the game crashes.

Code: Select all

Traceback (most recent call last):
  File "main.py", line 7, in <module>
  File "ui\Incantus.pyo", line 790, in main
  File "ui\Incantus.pyo", line 656, in run
  File "engine\GameKeeper.pyo", line 82, in start
  File "engine\GameKeeper.pyo", line 116, in run
  File "engine\GameKeeper.pyo", line 249, in mainPhase1
  File "engine\GameKeeper.pyo", line 393, in playSpells
  File "engine\Stack.pyo", line 40, in resolve
  File "engine\Ability\Ability.pyo", line 40, in resolve
  File "<string>", line 20, in effects
  File "engine\Player.pyo", line 169, in choose_from_zone
  File "engine\Player.pyo", line 505, in getCardSelection
IndexError: list index out of range


[MageKing17]

If you have an empty library (no cards) and try to search your library, the game crashes.

Code: Select all

Traceback (most recent call last):
  File "main.py", line 7, in <module>
  File "ui\Incantus.pyo", line 790, in main
  File "ui\Incantus.pyo", line 656, in run
  File "engine\GameKeeper.pyo", line 82, in start
  File "engine\GameKeeper.pyo", line 116, in run
  File "engine\GameKeeper.pyo", line 249, in mainPhase1
  File "engine\GameKeeper.pyo", line 393, in playSpells
  File "engine\Stack.pyo", line 40, in resolve
  File "engine\Ability\Ability.pyo", line 40, in resolve
  File "<string>", line 20, in effects
  File "engine\Player.pyo", line 169, in choose_from_zone
  File "engine\Player.pyo", line 505, in getCardSelection
IndexError: list index out of range


I'll put in a short-circuit to make any zone-search fail if the zone is empty... although I would've thought one would already be there.

[MageKing17]

I'd just like to self-report a couple of staggering bugs in v0.59 before I upload the v0.591 executable.

1) set_land() was causing a crash because stacked_land_subtype was a subclass of stacked_characteristic instead of stacked_subtype. This has been fixed in v0.591.
2) MultipleTargets was declaring just about every target as invalid due to a logic error. This has also been fixed in v0.591.

[juzamjedi]

Ajani Goldmane in play on my opponent's side of the board. I have a Caves of Koilos in play. I tap the land for colored mana and it asks if I want to redirect that damage to Ajani (again, Ajani is on my opponent's side of the board)

[MageKing17]

Ajani Goldmane in play on my opponent's side of the board. I have a Caves of Koilos in play. I tap the land for colored mana and it asks if I want to redirect that damage to Ajani (again, Ajani is on my opponent's side of the board)

Now that is interesting. It looks like the redirect code is adding itself to both Players without bothering to check if the victim of the damage is the planeswalker's controller. How silly. I'm correcting it immediately for v0.592.