New Draft Functionality Finally Done
by mtgrares
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: New Draft Functionality Finally Done
by friarsol » 31 May 2011, 11:53
I don't think we should let anyone Draft Chronicles (or have it exist in the list at all). Since it was a unique thing where it took some cards from The Dark, Arabian Nights, Antiquities and Legends and sold them as a combined package (mostly because these original 4 expansions weren't available overseas). None of the Cards that were actually in Chronicles have the SetInfo for Chronicles, which is probably why it's crashing.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: New Draft Functionality Finally Done
by Agetian » 31 May 2011, 11:59
Oh that makes sense, that would explain it. I'll wait for Rob's response and, if he doesn't mind and doesn't have time to remove it himself, I can remove the Chronicles from the draft list.friarsol wrote:I don't think we should let anyone Draft Chronicles (or have it exist in the list at all). Since it was a unique thing where it took some cards from The Dark, Arabian Nights, Antiquities and Legends and sold them as a combined package (mostly because these original 4 expansions weren't available overseas). None of the Cards that were actually in Chronicles have the SetInfo for Chronicles, which is probably why it's crashing.
It still doesn't explain the crasher in The Dark and certain other smaller sets though... That is still puzzling for me.
Thanks for your help friarsol!
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: New Draft Functionality Finally Done
by Rob Cashwalker » 31 May 2011, 14:02
Go ahead and remove it from the SetInfoUtil lists, just make sure that the set code doesn't show up in any of the card files.
I'm looking into the other one now.
I'm looking into the other one now.
The Force will be with you, Always.
-
Rob Cashwalker - Programmer
- Posts: 2167
- Joined: 09 Sep 2008, 15:09
- Location: New York
- Has thanked: 5 times
- Been thanked: 40 times
Re: New Draft Functionality Finally Done
by Agetian » 31 May 2011, 14:43
Alrighty, I commented it out for now, but it's easy to put it back in if necessary.Rob Cashwalker wrote:Go ahead and remove it from the SetInfoUtil lists, just make sure that the set code doesn't show up in any of the card files.
I'm looking into the other one now.
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: New Draft Functionality Finally Done
by Rob Cashwalker » 31 May 2011, 15:05
OK, fixed the error with drafting sets with odd rarity counts. The BoosterGenerator was initializing with 11 C, 3 U, 1 R, 0 M, 0 S. However the DRK.pack file only specified commons (6) and rares (2). The uncommons were being counted in BoosterGenerator.getBoosterPackSize(). So I revised it to initialize all the counts to 0, then explicitly set the values for each constructor.
The Force will be with you, Always.
-
Rob Cashwalker - Programmer
- Posts: 2167
- Joined: 09 Sep 2008, 15:09
- Location: New York
- Has thanked: 5 times
- Been thanked: 40 times
Re: New Draft Functionality Finally Done
by Agetian » 31 May 2011, 15:06
Awesome, thanks for the update Rob!Rob Cashwalker wrote:OK, fixed the error with drafting sets with odd rarity counts. The BoosterGenerator was initializing with 11 C, 3 U, 1 R, 0 M, 0 S. However the DRK.pack file only specified commons (6) and rares (2). The uncommons were being counted in BoosterGenerator.getBoosterPackSize(). So I revised it to initialize all the counts to 0, then explicitly set the values for each constructor.

- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
66 posts
• Page 5 of 5 • 1, 2, 3, 4, 5
Who is online
Users browsing this forum: No registered users and 17 guests