MTGForge 04/19 (unofficial BETA) version

[DennisBergkamp]

New version:

Features / Fixes:

- Updated date displayed at the top from 02/2009 to 04/2009
- Added the ability to view removed cards from both the player's and computer's removed from game zone.
- New keywords: Protection from {color}, Shroud and Flanking.
- Hybrid mana is now supported, thank you rares Chris gave me the fixes in cards.txt to currently existing hybrid mana fakers in MTGForge.
- Rhys the Redeemed works now without resorting to hacky code (and he should trigger cards like Quirion Dryad now).
- Updated some cards in cards.txt that had protection / shroud data missing (Simic Sky Swallower, both Akroma Legends, White Shield Crusader, ... , to name a few).
- Added some AI code for Scarblade Elite (hopefully its AI side will actually work now?).
- Faceless Butcher, Oblivion Ring and Oubliette should actually return the removed cards back to play again.
- Fixed Seizan, Perverter of Truth.
- Fixed Flame Spirit.
- Fixed Wild Nacatl.
- Fixed Meng Huo, Barbarian King.
- Fixed creatures with Fear being able to get blocked by face down morphs.
- Fixed Wydwen the Biting Gale (I think?).
- Nicol Bolas AI (first ability) should be fixed.
- Fixed being unable to assign damage to multiple blockers when using the old non-resizable GUI.
- Fixed Kiki-Jiki, Mirror Breaker targeting facedown creatures, and those creatures turning face up.
- Fixed Anaba Shaman text.
- Merged a bunch of Rob's changes which removes warnings for the later java versions.
- Fixed a big bug where during the "Combat damage is on the stack" phase if a creature that has assigned damage to another creature leaves play, the damage would not resolve.
- Fixed Keening Banshee (will give target -2/-2 until EOT instead of dealing 2 damage to it).
- Fixed Man-o'-War where if the only creature on the human's side leaves play in response to Man-o'-War coming into play, it will target itself instead of null.
- Stonecloaker should be fixed.


New Cards

A lot, too many to list, but here's a few of the coolest:
Divinity of Pride, Cold-Eyed Selkie, Scion of Oona, Blastoderm / Calciderm, Eladamri, Lord of Leaves, Crystalline Sliver, Sidewinder Sliver, Nimble Mongoose, White Knight, Black Knight, Argothian Enchantress.

Main stuff to test would obviously be the protection from and shroud stuff. There's a lot of code that had to be updated all over the place... so I'm sure there will be a bunch of new bugs.

[GandoTheBard]

Wow dennis great work. Particularly on the Removed cards area and the fixes.

[GandoTheBard]

You did a much better job this time of getting all the images too. Only one slipped through your grasp..the evil Obsidian Acolyte...but that leads me to Corrupt Official which is completely wrong. It should say "Whenever Corrupt Official is blocked the defender discards a random card from his/her hand." not "Whenever Corrupt Official becomes blocked, you may draw a card." which is what it currently says.

[GandoTheBard]

One more comment. I was sure I read somewhere that the incredibly insufficiency of red cards in the Quest mode would be addressed in the next build. Was I mistaken? Because I notice once again that I get 11-19 of each other color and 4-7 red cards. Is this on purpose? Do you guys really hate/fear red so much? lol. Please fix this asap if it is possible.

[Mr.Chaos]

Looks like a great update again. Thanks to all who helped with it.
Oh, oh. I see flanking has made it into the game. I will test that as I recal the problems we had here with other cards that gave minus p/t effects to cards.
However, seeing as I am a bit busy in real life at the mo, it ay be a few days before I actually start commenting on the good and bad of this beta.

[DennisBergkamp]

You did a much better job this time of getting all the images too. Only one slipped through your grasp..the evil Obsidian Acolyte...but that leads me to Corrupt Official which is completely wrong. It should say "Whenever Corrupt Official is blocked the defender discards a random card from his/her hand." not "Whenever Corrupt Official becomes blocked, you may draw a card." which is what it currently says.

Gotta thank Chris for that, he makes the updates to both rarities and card-pictures.txt. Except, I added three extra cards kind of last minute: Armored Guardian, Obsidian Acolyte and Crimson Acolyte. I see what I did wrong for Obsidian Acolyte, I named him obisidian_acolyte.jpg in card-pictures.txt. Which should of course be obsidian_acolyte.jpg

The reason I added these is because they make good cards for testing, giving something Pro red in response to a red spell targeting that creature, should make the spell fizzle, same deal with shroud.
Another thing that comes to mind however, is that the AI will obviously use these cards very clumsily (i.e. spend all his mana giving his creatures Protection from x each turn).

I guess I messed up on Corrupt Official a few versions ago, I'll look into it.
EDIT: it looks like its just the text in cards.txt that's messed up.

One more comment. I was sure I read somewhere that the incredibly insufficiency of red cards in the Quest mode would be addressed in the next build. Was I mistaken? Because I notice once again that I get 11-19 of each other color and 4-7 red cards. Is this on purpose? Do you guys really hate/fear red so much? lol. Please fix this asap if it is possible.

Oops, forgot about this... I'll add this along with some fixes to other bugs that will come up, and post a new version in the next few days.

[mtgrares]

Very great thanks. I didn't think MTG Forge would ever supports protection or shroud (shroud should really help against those nasty blue bouncy decks or black decks with ton of removal). The only reason MTG Forge supports those keywords is thanks to DennisBergkamp's dedication.

And just a quick note. I saw your comment in Input_CombatDamage.damageCreatureAndPlayer().

//why???
/*
life = AllZone.GameAction.getPlayerLife(AllZone.Combat.getAttackingPlayer());
life.subtractLife(AllZone.Combat.getAttackingDamage());
life.subtractLife(AllZone.pwCombat.getAttackingDamage());
*/

Well, I thought the attacking player could be damaged by a trample blocker. Later I realized that trample only work when attacking.

Feel free to ask me any other questions that you may have about my code. Although you seem to understand it well enough because even I didn't dare protection.

[DennisBergkamp]

Ahhh, that explains it

[Chris H.]

Wow, an impressive release.

For those who are interested, I will provide what I think is the list of new cards.

Code: Select all

Argothian Enchantress
Armored Guardian
Ashenmoor Gouger
Benalish Cavalry
Black Knight
Blastoderm
Boggart Ram-Gang
Boros Guildmage
Boros Recruit
Burning Shield Askari
Cadaverous Knight
Calciderm
Cold-Eyed Selkie
Crimson Acolyte
Crystalline Sliver
Deadly Insect
Deft Duelist
Divinity of Pride
Eladamri, Lord of Leaves
Elvish Lookout
Fallen Askari
Femeref Knight
Giant Solifuge
Harvest Gwyllion
Hawkeater Moth
Hearthfire Hobgoblin
Hobgoblin Dragoon
Humble Budoka
Inkfathom Infiltrator
Inkwell Leviathan
Iridescent Angel
Jabari's Banner
Jolrael's Centaur
Loamdragger Giant
Mourning Thrull
Mtenda Herder
Nimble Mongoose
Nip Gwyllion
Obsidian Acolyte
Odious Trow
Old Ghastbark
Oona's Gatewarden
Oversoul of Dusk
Pincher Beetles
Plumeveil
Scion of Oona
Scuzzback Scrapper
Shadow Rider
Sidewinder Sliver
Stalker Hag
Stillmoon Cavalier
Stream Hopper
Suq'Ata Lancer
Wasp Lancer
White Knight
Wilt-Leaf Cavaliers
Wistful Selkie
Zealous Guardian
Zephid
Zhalfirin Knight

[GandoTheBard]

I was going to add the following cards but realized you hardcoded the slith abilities rather than making it into a keyword:
Whirling Dervish, and Dunerider Outlaw

I know these cards' abilities happen at the End of Turn but I was hoping to at least see them.

[Chris H.]

I was going to add the following cards but realized you hardcoded the slith abilities rather than making it into a keyword:
Whirling Dervish, and Dunerider Outlaw

I know these cards' abilities happen at the End of Turn but I was hoping to at least see them.

I like running these types of tests just to see if it will work or not. I just tried to enter the data for Flame Javelin, but it did not work. It looks like it would be a fun burn spell for a non red deck.

[jpb2]

I don't even want to know how long it took to add protection. Insane!

[Chris H.]

I would like to thank everyone for this update. I am still trying to absorb all of the new stuff.

I now like the looks of the card Rhys the Redeemed. Have not yet tried to abuse the computer with this card at this time.

If Rob gets a chance someday, we would like to hear more about the code changes that he is making.

I have spent a few hours with Eclipse and was able to complete the simple hello world example. The more difficult hello world in a window using swt-3.4 - ouch - two warnings and it would not compile. I doubt that I will ever reach a point where I can get the source to compile on my Mac.

[Rob Cashwalker]

All of the updates I've been feeding Dennis have been to deal with all the warnings that cause eclipse to become sluggish as it paints the screen with icons and under-lines....

Stuff like type safety checks, mostly seen with the ArrayList object.

Stuff like classes being defined as serializable, but not declaring a SerialUID. This is by far the biggest offender, and CardFactory is FULL of them, so many that Java only reports 100 warnings at a time, so I don't know how many more there are, but I'm probably more than half-done with them.

Stuff like variables declared but never read.

I want to help clean these things up so that I can get back to real code. All the warnings clutter up the screen, and it affects my OCD.... So I figure that I might as well clean up as much as I can, because it's only going to get worse as more cards and features come in. Dennis wasn't fixing it, but he's got a lot of major stuff on his development. I just found this niche where I could help....

[DennisBergkamp]

I personally don't really care about the warnings (that's how messy of a person I am I guess ), and my computer seems to have enough power to handle the warning-"spell checker".
But once you got all warnings fixed, I'll merge all of your changes into CardFactory. Then for every new card/feature I add, I'll make sure they're warning free.

I like running these types of tests just to see if it will work or not. I just tried to enter the data for Flame Javelin, but it did not work. It looks like it would be a fun burn spell for a non red deck.

Hmm, I could've sworn I grabbed rares' updated hybrid mana code and merged it with my version... Guess not, I'll do it (again?) and make sure Flame Javelin works this time.