Page 33 of 155

Re: Feature Requests Thread

PostPosted: 30 Aug 2011, 08:48
by Accountancy
Would it be possible to add functionality so that when you click on a creature to make it attack, clicking on it again will stop it from being declared as an attacker, as yet, if you accidentally click on a creature during the declare attackers step, you have to live with your decision and the creature usually dies.

Re: Feature Requests Thread

PostPosted: 30 Aug 2011, 09:08
by Sloth
Accountancy wrote:Would it be possible to add functionality so that when you click on a creature to make it attack, clicking on it again will stop it from being declared as an attacker, as yet, if you accidentally click on a creature during the declare attackers step, you have to live with your decision and the creature usually dies.
Good news. This feature is also there: Try right clicking on the attacking creature. :D

Re: Feature Requests Thread

PostPosted: 30 Aug 2011, 10:36
by Accountancy
awesome!

Re: Feature Requests Thread

PostPosted: 03 Sep 2011, 09:37
by Accountancy
Could we please do away with the function that after you win 2 games in a match, you get no option to repeat the match? It just gives the player less choice and when playing with randomly generated decks, if you want to play more than three games, you have to purposely lost the last one.

Re: Feature Requests Thread

PostPosted: 03 Sep 2011, 10:24
by slapshot5
Accountancy wrote:Could we please do away with the function that after you win 2 games in a match, you get no option to repeat the match? It just gives the player less choice and when playing with randomly generated decks, if you want to play more than three games, you have to purposely lost the last one.
That's not a feature request. That's a straight up bug. I don't know what the right fix is. It looks like it got integrated with the quest stuff somehow.

-slapshot5

Re: Feature Requests Thread

PostPosted: 03 Sep 2011, 13:33
by Max mtg
slapshot5 wrote:
Accountancy wrote:Could we please do away with the function that after you win 2 games in a match, you get no option to repeat the match? It just gives the player less choice and when playing with randomly generated decks, if you want to play more than three games, you have to purposely lost the last one.
That's not a feature request. That's a straight up bug. I don't know what the right fix is. It looks like it got integrated with the quest stuff somehow.

-slapshot5
I don't see this bug in my development build. Accountancy, what version are you using?

Re: Feature Requests Thread

PostPosted: 03 Sep 2011, 17:17
by slapshot5
Max mtg wrote:
slapshot5 wrote:
Accountancy wrote:Could we please do away with the function that after you win 2 games in a match, you get no option to repeat the match? It just gives the player less choice and when playing with randomly generated decks, if you want to play more than three games, you have to purposely lost the last one.
That's not a feature request. That's a straight up bug. I don't know what the right fix is. It looks like it got integrated with the quest stuff somehow.

-slapshot5
I don't see this bug in my development build. Accountancy, what version are you using?
I see it in my svn version. r10193. Just play a 1 game (non-quest) and win it. Notice the restart button is enabled. It should only be enabled if you or the computer have won 2 games, and thus, the match.

-slapshot5

Edit: The problem is in Gui_WinLose.java about line 107:

restartButton.setEnabled(!model.match.isMatchWonByHuman());

Re: Feature Requests Thread

PostPosted: 03 Sep 2011, 17:39
by Sloth
slapshot5 wrote:
Edit: The problem is in Gui_WinLose.java about line 107:

restartButton.setEnabled(!model.match.isMatchWonByHuman());
Good find. I think it's best to always enable it.

Re: Feature Requests Thread

PostPosted: 03 Sep 2011, 18:25
by slapshot5
Sloth wrote:
slapshot5 wrote:
Edit: The problem is in Gui_WinLose.java about line 107:

restartButton.setEnabled(!model.match.isMatchWonByHuman());
Good find. I think it's best to always enable it.
What I described was the way it worked for as long as I can remember. However, I would not object to it being enabled all the time.

-slapshot5

Re: Feature Requests Thread

PostPosted: 04 Sep 2011, 04:08
by Accountancy
slapshot5 wrote:
Sloth wrote:
slapshot5 wrote:
Edit: The problem is in Gui_WinLose.java about line 107:

restartButton.setEnabled(!model.match.isMatchWonByHuman());
Good find. I think it's best to always enable it.
What I described was the way it worked for as long as I can remember. However, I would not object to it being enabled all the time.

-slapshot5
That's what I'd like to see. I simply meant that the restart button should always be usable, I can't think of a reason for not letting the player restart a match.

Re: Feature Requests Thread

PostPosted: 04 Sep 2011, 18:55
by Max mtg
Accountancy wrote:That's what I'd like to see. I simply meant that the restart button should always be usable, I can't think of a reason for not letting the player restart a match.
Last time I disabled it in order not to confuse the player who has won a match in quest mode and would like to just claim his reward (and not ocasionally hit restart to launch the match once more)

Maybe it should just be auto-clicked then? I mean once player won a match in quest mode, he is not even shown this window, but directly proceeds to receiving all prizes?

Re: Feature Requests Thread

PostPosted: 04 Sep 2011, 19:18
by Sloth
Max mtg wrote:
Accountancy wrote:That's what I'd like to see. I simply meant that the restart button should always be usable, I can't think of a reason for not letting the player restart a match.
Last time I disabled it in order not to confuse the player who has won a match in quest mode and would like to just claim his reward (and not ocasionally hit restart to launch the match once more)

Maybe it should just be auto-clicked then? I mean once player won a match in quest mode, he is not even shown this window, but directly proceeds to receiving all prizes?
Now that you mention this, I'm not sure why this button is enabled in quest mode anyway. If you start a match in quest mode you shouldn't be able to restart it until you win, or?

Re: Feature Requests Thread

PostPosted: 04 Sep 2011, 19:32
by Max mtg
Sloth wrote:
Max mtg wrote:Last time I disabled it in order not to confuse the player who has won a match in quest mode and would like to just claim his reward (and not ocasionally hit restart to launch the match once more)

Maybe it should just be auto-clicked then? I mean once player won a match in quest mode, he is not even shown this window, but directly proceeds to receiving all prizes?
Now that you mention this, I'm not sure why this button is enabled in quest mode anyway. If you start a match in quest mode you shouldn't be able to restart it until you win, or?
It is because of your change in r10215 to make it always enabled.

Re: Feature Requests Thread

PostPosted: 05 Sep 2011, 18:49
by Sloth
Max mtg wrote:
Sloth wrote:Now that you mention this, I'm not sure why this button is enabled in quest mode anyway. If you start a match in quest mode you shouldn't be able to restart it until you win, or?
It is because of your change in r10215 to make it always enabled.
What I meant is, that it shouldn't be available in quest mode (no matter if you win or not).

Re: Feature Requests Thread

PostPosted: 08 Sep 2011, 22:12
by inb63
What about Kamigawa flip cards and the Innistrad transform mechanic? It would be so much fun to be able to use those cards in Forge :mrgreen: