Page 3 of 5

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 02:43
by Chris H.
Hmmm, the error statement once again mentions an invalid card name, but I compared the card name for this card in both cards.txt and CardFactory_Creatures.java and the name appears to match.

Sir SF will hopefully see this error and understand what is causing it.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 03:17
by sdh
I registered to say that I have the merfolk looter error as well.
I can't even download the card picture.
The name looks correct in cards.txt but when I open the deck editor, the card is listed as "Merfolk Looter" rather than "Merfolk Looter". Also the place holder for the picture is listed as "ïmerfolk_looter.jpg". Maybe the problem is with these strange  characters?

Another mistake in my deck editor is that the type for Ire of Kaminari is listed as "Instant — Arcane" rather than "Instant - Arcane".

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 06:59
by Mr.Chaos
Thanks for the update guys.
Too bad about the bugs.
I see the update, grab it, read the rest of the posts, see another update, grab that too.
You are keeping me busy. :lol:
(That is what I get for not being online much yesterday, 3 whole pages added to a new thread! :shock: )

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 07:31
by Marek14
Benalish Hero? Did you implement banding? :shock:

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 10:20
by silly freak
the looter seems to be a character encoding problem - i wonder if this is because i changed the file (on linux)...
and how we can fix it. i think i had the same problem with the properties systems, and I used an InputStream instead of a Reader. that could maybe help?

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 11:11
by Chris H.
Thermal Blast also has a character encoding problem. It's threshold states:

Threshold — Thermal Blast deals 5 damage to that creature instead if seven or more cards are in your graveyard.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 14:18
by Fracturedorb
When you give the Apprentice Wizard a blue mana he gives you back 1 colorless instead of 3.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 14:23
by Fracturedorb
Also, the new mana pool acts wierd in general. Now whan I cast a dark ritual It's possible to cast a 4 cost spell by just clicking on the mana pool 4 times even though it shows it only has 3 mana available.

Also sometimes after I cast a spell with mana left over in the pool the mana goes away.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 15:41
by Corwin72
I will second this. I just did not know how to verbalize it.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 16:35
by DennisBergkamp
Marek14 wrote:Benalish Hero? Did you implement banding? :shock:
Err, oops, no. I accidentally named Benalish Trapper Benalish Hero at first. I guess card-pictures.txt still had the reference to this.

Anyway, so it seems that the Merfolk Looter problem is because of some text formatting error... what's weird is that I'm not seeing any trouble with Merfolk Looter (I did see a few "—" in different cards though), and it works fine on my PC.

Could someone try the cards.txt in this attachment, I've gone through and removed all of the "—"s.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 21:12
by DennisBergkamp
Still the same problems then?

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 21:33
by Chris H.
Merfolk Looter, Thermal Blast and Ire of Kaminari looks OK to me. Here are a few other fairly minor corrections for you:

Code: Select all
Adun Oakenshield
G R B
Legendary Creature Human Knight
B R G, T: Return target creature card from your graveyard to your hand.
1/2

Inspiration
3 U
Sorcery
no text
spDrawCardsTgt:2:Target player draws two cards.:Inspiration - draw 2 cards.

Reach of Branches
4 G
Tribal Instant Treefolk
Put a 2/5 green Treefolk Shaman creature token into play.  Whenever a Forest comes into play under your control, you may return Reach of Branches from your graveyard to your hand.

Sacred Nectar
1 W
Sorcery
no text

Scavenged Weaponry
2 B
Enchantment Aura
Enchanted creature gets +1/+1. Draw a card.
Enchant creature
Cantrip

Shield of Duty and Reason
W
Enchantment Aura
Enchanted creature has protection from green and from blue.
Enchant creature

Thornscape Apprentice
G
Creature Human Wizard
no text
1/1
TgtKPump R T:First Strike
`

The activation cost for Xira Arien is "B R G, T: Target player draws a card."

The Reach of Branches fix will allow the Treefolk Harbinger to fetch this card.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 03 Nov 2009, 22:25
by DennisBergkamp
Alright, thanks :) I've just fixed them in my local version.

But what about the game crashing bugs... do they still occur with the cards.txt I submitted?

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 04 Nov 2009, 00:19
by sdh
merfolk looter, etc have been fixed in my version.
thanks

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 04 Nov 2009, 00:50
by Chris H.
DennisBergkamp wrote:But what about the game crashing bugs... do they still occur with the cards.txt I submitted?
`
I tried using your cards.txt file on my Mac, I pressed the Quest Mode button and I get this error:

Code: Select all
An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgrares@yahoo.com

CardFactory : getCard() invalid card name - Asha's favor

Detailed error trace:
java.lang.RuntimeException: CardFactory : getCard() invalid card name - Asha's favor
   at forge.CardFactory.getCard2(CardFactory.java:380)
   at forge.CardFactory.getCard(CardFactory.java:120)
   at forge.QuestData_BoosterPack.setup(QuestData_BoosterPack.java:242)
   at forge.QuestData_BoosterPack.<init>(QuestData_BoosterPack.java:102)
   at forge.QuestData.<init>(QuestData.java:67)
   at forge.Gui_QuestOptions.<init>(Gui_QuestOptions.java:29)
   at forge.Gui_NewGame$2.actionPerformed(Gui_NewGame.java:225)
   at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
   at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
   at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
   at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
   at java.awt.Component.processMouseEvent(Component.java:6348)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
   at java.awt.Component.processEvent(Component.java:6113)
   at java.awt.Container.processEvent(Container.java:2085)
   at java.awt.Component.dispatchEventImpl(Component.java:4714)
   at java.awt.Container.dispatchEventImpl(Container.java:2143)
   at java.awt.Component.dispatchEvent(Component.java:4544)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4618)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4282)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4212)
   at java.awt.Container.dispatchEventImpl(Container.java:2129)
   at java.awt.Window.dispatchEventImpl(Window.java:2475)
   at java.awt.Component.dispatchEvent(Component.java:4544)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:635)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
`
I tried the same test with my heavily modified and corrected cards.txt file and I get to the Quest Options screen. When I press the New Quest button I get this different error message:

Code: Select all
An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgrares@yahoo.com

Deck cannot be cast to forge.Deck

Detailed error trace:
java.lang.ClassCastException: Deck cannot be cast to forge.Deck
   at forge.QuestData.getDeckFromMap(QuestData.java:286)
   at forge.QuestData.ai_getDeck(QuestData.java:278)
   at forge.Gui_QuestOptions.copyAIDecks(Gui_QuestOptions.java:208)
   at forge.Gui_QuestOptions.newQuestButton_actionPerformed(Gui_QuestOptions.java:192)
   at forge.Gui_QuestOptions$3.actionPerformed(Gui_QuestOptions.java:137)
   at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
   at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
   at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
   at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
   at java.awt.Component.processMouseEvent(Component.java:6348)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
   at java.awt.Component.processEvent(Component.java:6113)
   at java.awt.Container.processEvent(Container.java:2085)
   at java.awt.Component.dispatchEventImpl(Component.java:4714)
   at java.awt.Container.dispatchEventImpl(Container.java:2143)
   at java.awt.Component.dispatchEvent(Component.java:4544)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4618)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4282)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4212)
   at java.awt.Container.dispatchEventImpl(Container.java:2129)
   at java.awt.Window.dispatchEventImpl(Window.java:2475)
   at java.awt.Component.dispatchEvent(Component.java:4544)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:635)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
`
I include my personalized cards.txt file below. It has about a dozen additional minor fixes. You can build a project with my and your versions of the cards.txt files to see the differences and do a compare on them. Not sure that this will help.

`