Page 5 of 5

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 06 Nov 2009, 03:03
by Corwin72
Blightspeaker is missing it's first ability.
It can not tap to have player lose one life.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 06 Nov 2009, 05:56
by indicatie
DennisBergkamp wrote:Is it possible to somehow revert the manapool changes?
Another problem I'm getting is that I can actually cast 5 manacost spells, even though I only have 4 moxes in play :shock:
Not just with 4..... I can play my Exalted Angel face-up, with just 1 (ONE!) Plains in play! :rolleyes:

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 06 Nov 2009, 17:59
by mtgrares
indicatie wrote:
DennisBergkamp wrote:Is it possible to somehow revert the manapool changes?
Another problem I'm getting is that I can actually cast 5 manacost spells, even though I only have 4 moxes in play :shock:
Not just with 4..... I can play my Exalted Angel face-up, with just 1 (ONE!) Plains in play! :rolleyes:
The problem might be with Input_PayManaCost.java. It was very tricky to write correctly. One of the major errors that I had was that you were able to generate more mana than you really had by clicking the Cancel button.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 07 Nov 2009, 00:11
by zerker2000
Whatever the problem is, it is obviously entirely my fault :(.
@mtgrares: Input_PayManaCost(Util) has been modified by my original mana pool update, including some of the undo code. I think it now adds mana abilities to tappedLand instead of cards, whose undo() gets called.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 07 Nov 2009, 07:50
by indicatie
mtgrares wrote:
indicatie wrote:
DennisBergkamp wrote:Is it possible to somehow revert the manapool changes?
Another problem I'm getting is that I can actually cast 5 manacost spells, even though I only have 4 moxes in play :shock:
Not just with 4..... I can play my Exalted Angel face-up, with just 1 (ONE!) Plains in play! :rolleyes:
The problem might be with Input_PayManaCost.java. It was very tricky to write correctly. One of the major errors that I had was that you were able to generate more mana than you really had by clicking the Cancel button.
You don't have to abuse the cancel button. Just tap the land to add mana to your mana pool, click the card to play it, then keep clicking the mana pool until the card is played....

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 08 Nov 2009, 06:06
by zerker2000
I also seem to have fixed the "pool empties when you play spell" problem: for some reason, it cleared the mana pool contents instead of its "paid" list :?.

EDIT: And the mana remaining issue, it seems I once again treated String.replaceFirst() as a void :oops:. Also, the sol ring error seems to be a mostly graphical one, with both mana actually being added to the pool ... I did change ManaPool.subtractOne a bit, it seems to be working normally...

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 08 Nov 2009, 19:53
by DennisBergkamp
Awesome!!! That's great news, Zerker :)
I see you guys have made quite a few updates on the SVN... I'll update my local version with all of the changes and see if I can get them working.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 09 Nov 2009, 00:51
by DennisBergkamp
I've updated to the latest version... I see there are a lot of issues fixed with the manapool.
HOWEVER, I can still pay for a Magnivore with just 2 Mox Ruby in play.
Also, I can cast Sol Ring from my hand by just double clicking on it (I'll have one mana floating in the manapool - and the Sol Ring will enter play tapped).

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 09 Nov 2009, 03:38
by zerker2000
Eh? I wonder whether that works for grim monolith :)? Fixing...

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 10 Nov 2009, 18:46
by Resonantg
Just because I'm being extra dense, where can I go to get all the most current updates. SVN update?

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 10 Nov 2009, 19:32
by DennisBergkamp
Yeah, the SVN has the most recent build.

Our most stable build currently is probably 10/17. Although the SVN has a lot of bugs fixed that existed in 10/17, the SVN has some new stuff (which probably have a bug or two) and the ManaPool issues still aren't completely fixed.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 11 Nov 2009, 05:07
by zerker2000
Ah, I thank you for catching an important bug, one which might have in fact been there before the recent update. It seems the code managed to skip the canPlay() check if "mana of any color" was part of the cost. This allowed, for example, to play a gilded lotus using lands in your hand :). Fixed.

Re: MTGForge 11/01 (unofficial BETA) version

PostPosted: 11 Nov 2009, 18:39
by DennisBergkamp
Awesome =D> Yes, I just updated my local version with your SVN change, and the previous mana bugs are fixed now, it seems :)
I will release a new beta soon.