Add Basic Lands auto-suggestion logic ?

[BlueTemplar]

From :
Forge Beta Release 06/26/2017 ver 1.5.65
viewtopic.php?f=26&t=20769

Automatically Suggest Basic Lands in Deck Editor
It is now possible to ask Forge to automatically suggest basic lands for your deck in the Add Basic Lands dialog of the deck editor. In desktop Forge, this is accomplished by double-clicking the statistics text in the bottom part of the dialog (hopefully someone will be able to code in a better, more intuitive way of doing this eventually). In mobile Forge, this is done by double tapping the statistics text. A tooltip is available in desktop Forge (and a hint text in mobile Forge) to make this feature more visible. Three deck sizes are supported by this algorithm: 40-card decks (if the number of cards in the main portion of the deck is less than 30, the algorithm will target a 40-card deck), 60-card decks (if the number of cards in the main portion is between 30 and 60, a 60-card deck will be targeted), and 100-card decks (if the deck is already above 60 cards when the feature is used, a 100-card deck will be targeted).

My problem with this is that, if I'm reading the Java right in DeckgenUtil.java, is that instead of targeting a percentage of mana sources, it only tries to "fill the deck up" to the breakpoints of 40, 60, or 100 cards !
(The rest of the algorithm already seems to be pretty fancy, taking into account mana shards.)

Proof :

Code (line 787) :

Code: Select all

        int sizeNoLands = cards.size() - numLands;

        // attempt to determine if building for sealed, constructed or EDH
        int targetDeckSize = sizeNoLands < 30 ? 40
                : sizeNoLands > 60 ? 100 : 60;

        int numLandsToAdd = targetDeckSize - cards.size();


While, surely, it's much more important to have a balanced number of lands, rather than just "fill up" the deck ?!

Considering how the usual suggestion seems to be 17 lands out of 40 cards for Limited (42.5%) and 24 out of 60 cards for Constructed (40%),
overall the land suggester should instead aim at around 40.8% lands in the deck instead of "completing" ?

(Also, maybe the priority of lands should be Forest > Island > Mountain > Swamp > Plains, considering the mana-fixing affinity of these colors ?)