It is currently 07 Jul 2021, 21:53
   
Text Size

AbilityCost toString

Moderators: timmermac, friarsol, Blacksmith, KrazyTheFox, Agetian, CCGHQ Admins

AbilityCost toString

Postby sentient6 » 11 Jan 2011, 22:34

Judging from the oracle text at [url]gatherer.wizards.com[/url], AbilityCost.toString() does not seem to correctly handle conversion of Sacrifice, Exile, Remove Counter, etc. costs which require just one target, or that cause loss of one life.

Gain and loss text should, I believe, state "Pay 1 life" instead of "Pay one life" and sacrifice type text should read "Sacrifice a creature" not "Sacrifice one creature".

It seems that this could be fixed by changing the numNames array and modifying the toString method slightly. I just wanted to make sure that I'm correct about this and that the current text is not by design before I commit the changes.
sentient6
 
Posts: 13
Joined: 03 Jan 2011, 00:48
Has thanked: 0 time
Been thanked: 0 time

Re: AbilityCost toString

Postby friarsol » 11 Jan 2011, 22:51

Go for it. This text shouldn't have any effect on how Cost works, and the toString portion of Cost was simplified to use numbers instead of how the actual Oracle text so there wouldn't be any "Sacrifice a artifact" issues.
friarsol
Global Moderator
 
Posts: 7575
Joined: 15 May 2010, 04:20
Has thanked: 242 times
Been thanked: 956 times


Return to Forge

Who is online

Users browsing this forum: No registered users and 13 guests


Who is online

In total there are 13 users online :: 0 registered, 0 hidden and 13 guests (based on users active over the past 10 minutes)
Most users ever online was 1922 on 07 Jun 2021, 06:01

Users browsing this forum: No registered users and 13 guests

Login Form