Page 5 of 5

Re: New Draft Functionality Finally Done

PostPosted: 31 May 2011, 11:53
by friarsol
I don't think we should let anyone Draft Chronicles (or have it exist in the list at all). Since it was a unique thing where it took some cards from The Dark, Arabian Nights, Antiquities and Legends and sold them as a combined package (mostly because these original 4 expansions weren't available overseas). None of the Cards that were actually in Chronicles have the SetInfo for Chronicles, which is probably why it's crashing.

Re: New Draft Functionality Finally Done

PostPosted: 31 May 2011, 11:59
by Agetian
friarsol wrote:I don't think we should let anyone Draft Chronicles (or have it exist in the list at all). Since it was a unique thing where it took some cards from The Dark, Arabian Nights, Antiquities and Legends and sold them as a combined package (mostly because these original 4 expansions weren't available overseas). None of the Cards that were actually in Chronicles have the SetInfo for Chronicles, which is probably why it's crashing.
Oh that makes sense, that would explain it. I'll wait for Rob's response and, if he doesn't mind and doesn't have time to remove it himself, I can remove the Chronicles from the draft list.
It still doesn't explain the crasher in The Dark and certain other smaller sets though... That is still puzzling for me.
Thanks for your help friarsol!

- Agetian

Re: New Draft Functionality Finally Done

PostPosted: 31 May 2011, 14:02
by Rob Cashwalker
Go ahead and remove it from the SetInfoUtil lists, just make sure that the set code doesn't show up in any of the card files.

I'm looking into the other one now.

Re: New Draft Functionality Finally Done

PostPosted: 31 May 2011, 14:43
by Agetian
Rob Cashwalker wrote:Go ahead and remove it from the SetInfoUtil lists, just make sure that the set code doesn't show up in any of the card files.
I'm looking into the other one now.
Alrighty, I commented it out for now, but it's easy to put it back in if necessary.

Re: New Draft Functionality Finally Done

PostPosted: 31 May 2011, 15:05
by Rob Cashwalker
OK, fixed the error with drafting sets with odd rarity counts. The BoosterGenerator was initializing with 11 C, 3 U, 1 R, 0 M, 0 S. However the DRK.pack file only specified commons (6) and rares (2). The uncommons were being counted in BoosterGenerator.getBoosterPackSize(). So I revised it to initialize all the counts to 0, then explicitly set the values for each constructor.

Re: New Draft Functionality Finally Done

PostPosted: 31 May 2011, 15:06
by Agetian
Rob Cashwalker wrote:OK, fixed the error with drafting sets with odd rarity counts. The BoosterGenerator was initializing with 11 C, 3 U, 1 R, 0 M, 0 S. However the DRK.pack file only specified commons (6) and rares (2). The uncommons were being counted in BoosterGenerator.getBoosterPackSize(). So I revised it to initialize all the counts to 0, then explicitly set the values for each constructor.
Awesome, thanks for the update Rob! :)

- Agetian