Cards.

[jpb]

Here are the diamonds. Add this to CardFactory.java

Code: Select all

//*************** START *********** START **************************
     else if(cardName.equals("Charcoal Diamond") || cardName.equals("Moss Diamond") || cardName.equals("Sky Diamond") || cardName.equals("Fire Diamond") || cardName.equals("Marble Diamond"))
     {
       Command comesIntoPlay = new Command()
       {
         public void execute()
         {
           card.tap();
         }//execute()
       };
       card.setComesIntoPlay(comesIntoPlay);
     }//*************** END ************ END **************************

and this to cards.txt

Code: Select all

Charcoal Diamond
2
Artifact
Charcoal Diamond comes into play tapped.
tap: add B

Moss Diamond
2
Artifact
Moss Diamond comes into play tapped.
tap: add G

Sky Diamond
2
Artifact
Sky Diamond comes into play tapped.
tap: add U

Fire Diamond
2
Artifact
Fire Diamond comes into play tapped.
tap: add R

Marble Diamond
2
Artifact
Marble Diamond comes into play tapped.
tap: add W


you'll need to get the urls if you want the images.

[mtgrares]

Thanks for the cards. I'll get the urls.

[jpb]

Once Rob's code is in MTG Forge remind me to use the comesIntoPlayTapped keyword on these and remove this code from CardFactory.java.

[Rob Cashwalker]

Code: Select all

if (card.getKeyword().contains("Comes into play tapped."))
{
      card.setComesIntoPlay(new Command()
      {
        public void execute()
        {
          card.tap();
        }
      });
}


Searching Magiccards.info for "comes into play tapped" really just amounts to a ton of lands... and a couple artifacts. Almost all of which deal with producing mana in ways we can't do right now. It seems that MTGForge can only deal with mana from permanents that say "tap: add {mana}". There looks like card-specific code to deal with painlands, but I don't think they're actually implemented yet. I'd rather see a keyword to indicate painland ability. like "pain: add {mana}" because there are a number of older lands that have this drawback.

EDIT - Abbreviating it as "CIPT" wasn't good, because then the card text would have "Comes into play tapped." and then the keyword would show "CIPT".... Unless a shouldCIPT() method was used to return the index of the keyword, and then removed from the array, like the Pump keyword. Might as well just spell out this keyword, like we already do for "this creature cannot block"

[GandoTheBard]

Ok but then how do you propose to indicate the pain? ... "pain (6): do something." for example?

[Rob Cashwalker]

Ok but then how do you propose to indicate the pain? ... "pain (6): do something." for example?

Well, there aren't any painlands (granted, "so far") that have a pain-per-use greater than 1. So just making Input_PayManaCost recognize "pain: add G" or "pain: add W" (Brushland) should be sufficient for any mana ability that uses it. I think Elves of Deep Shadow would work with this too. If it ever comes up, then we could make it like Pain1, Pain2, Pain3, etc... but by then, I hope v2 is workable, and we won't have to discuss it....

BTW, forge - what's the deal - are you willing to keep adding cards we work on or are you going to focus 100% on v2? After your reply to my last submission, I was pretty "heartbroken", but I was relieved to find the others here trying to carry v1 on until v2 was released.