Writing New Cards

[mtgrares]

I'm surprised people are posting the code for new cards. I think it is great. MTG Forge isn't perfect but I'm glad people enjoy it and that new cards can be added to it. MTG Forge can't support every card but it can implement a wide variety. So in case you don't know, as the author of MTG Forge, I say, "Play on, and have fun". Version 2 is slowly coming.

[DennisBergkamp]

Exactly, it can implement a wide variety, I think this is awesome. You did a great job Forge, I think there's hundreds of cards that can still be added easily!

Sometimes it's not as smooth... I was working on implementing Hunting Grounds the other day, and I thought I got it to work sort of (I don't think I used the right instance of "Ability" because whenever I had it trigger, it would ask me to pay a manacost of 0), but then I tried putting a Mystic Snake into play with it, countering something my opponent was playing. It's weird, every time I did this it would counter my opponent's spell, but my Mystic Snake would end up in the graveyard as well Some other cards are probably very difficult or even impossible to implement into the current system, but that's understandable, looking at the complexity of MTG.

One thing I would really like to see in V2 is the ability to add creatures that have triggered abilities when attacking and/or dealing combat damage.
Until then I'll just keep adding random cards to V1

[Rob Cashwalker]

Well, I'm just doing what I've been doing all along, but I figured I might as well post it in plain-view.

I just hope someone (and I hope it's you, mtgrares) has been compiling (in both the collection meaning and the code meaning) these, so that we can all enjoy.

[GandoTheBard]

Yeah I too would love to see these code snippets added, compiled and distributed.

[mtgrares]

Probably the best way to distribute new cards is for one person to add all new cards to their version of MTG Forge and send the source code to me (mtgrares yahoo com) or attach it to a post. The job wouldn't be easy and some of it would be tedious, but your effort would be redistributed to a bunch of other thankful people. Just a thought.

[Mr.Chaos]

I emailed mtgrares about just this thing earlier this week.
So many cards are added by so many people, but nobody has the whole package anymore.
Since I know nothing about coding, I am totally dependant on the beta releases by mtgrares or by one of you coders.

So, please, combine as much of the cards added lately and lets see a new beta so we ALL can enjoy these new cards.

[DennisBergkamp]

Alright, I'll submit my cards directly to Forge then. I'll try to only send the ones that are bug free....
Or maybe it would be easier to have a single thread here in the forums just for the purpose of submitting cards? Either way

[Chris H.]

Probably the best way to distribute new cards is for one person to add all new cards to their version of MTG Forge and send the source code to me (mtgrares yahoo com) or attach it to a post. The job wouldn't be easy and some of it would be tedious, but your effort would be redistributed to a bunch of other thankful people. Just a thought.

Assume for the moment that someone wanted to add a card to MTG Forge. Lets say the Onulet.

After doing some research we would find that this card has different rarities depending on which card set this was included within.

If we included the name for this card in all three files:

common.txt
uncommon.txt
rare.txt

then this card would show up too often. Would it be best to add the name Onulet to only common.txt and then let the user decide to increase/decrease the frequency?



Onulet
3
Artifact Creature - Construct
2/2
When Onulet is put into a graveyard from play, you gain 2 life.

Set/Rarity:
Masters Edition (Magic Online only) Common
Fourth Edition Rare
Revised Edition Rare
Antiquities Uncommon

[GandoTheBard]

I think we can disregard the commonalities introduced by the masters sets because they are very specialized to reflect a niche. On the other hand if Onulet was remade today it might very well be a common and if you really like it and want to see it in alot of drafts then you should select that rarity. Putting it in all three rarities will ensure it showing up doubles in some packs. I am pretty sure thats a good way to get a goofy draft but have fun with it I guess.

[mtgrares]

You can add the card name multiple times to common.txt, uncommon.txt, or rare.txt. So if you really want to see Shock, just add a bunch of them. The code that reads these files isn't "smart" so it just reads all the cards names and spits out booster packs.


common.txt
Shock
Shock
Shock
Shock
Shock
Shock
Shock
Shock
...other cards

[Rob Cashwalker]

This is how I thought it would work.

Gando, I'm going to pick up the code on the rarity editor again. Would you like to see this part implemented - to make a particular card more common?

[GandoTheBard]

This is how I thought it would work.

Gando, I'm going to pick up the code on the rarity editor again. Would you like to see this part implemented - to make a particular card more common?

Yeah I think that is a fairly useful idea. I think overall we want even distribution as per the way real packs run but if that isn't possible maybe the right twiddling with the frequencies (not rarity) of the cards will help with that.

[Chris H.]

I think we can disregard the commonalities introduced by the masters sets because they are very specialized to reflect a niche.

I'm sorry for not getting back to you earlier. I have been busy with research and have found over 50 cards that I believe can be added without any additional coding.

I will want to add these cards to common.txt, uncommon.txt and to rare.txt. I'm not familiar enough with the various card sets and which of these are considered master sets. Can you explain to me which specific sets you are refering to. Please.

[GandoTheBard]

The Masters sets I & II are called just that. They are online only and are immediately classed as being Classic only cards. (Some of them may be in other sets that are not restricted to classic but thats a different story.)

[Chris H.]

The Masters sets I & II are called just that. They are online only and are immediately classed as being Classic only cards. (Some of them may be in other sets that are not restricted to classic but thats a different story.)

Thank you. Looking through my database I see that some of the cards are included in the following set:

Masters Edition II (Magic Online only)

I will ignore the rarity value for this card set.