Page 18 of 441

Ajani Goldmane Ultimate

PostPosted: 27 Feb 2009, 19:17
by mtgrares
The creature that Ajani Goldmane creates doesn't change its power and toughness if your life points change like Serra Avatar (which I programmed.) A quick fix would be for Ajani Goldmane to create a token named Serra Avatar and it should work correctly.

I know that a bug list can be overwhelming, so I'm reporting this "in case you don't know but you really want to know, lol"

Vampire Bats

PostPosted: 27 Feb 2009, 19:21
by mtgrares
By the way, has the AI ever attacked with Vampire Bats? It doesn't seem to...
Probably not, since the computer won't attack with 0/X creatures and the computer only plays certain spell/abilities during the Main1 phase. In ComputerAI_General.getMain1PlayHand(), there is a very long list of everything that the computer will play during its Main1. I did this in order to make the computer a little bit better, but I'm not sure if it really helps or not. Obviously this list could be updated with new cards or the list could be removed completely.

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 19:23
by DennisBergkamp
The creature that Ajani Goldmane creates doesn't change its power and toughness if your life points change like Serra Avatar (which I programmed.) A quick fix would be for Ajani Goldmane to create a token named Serra Avatar and it should work correctly.
I just fixed this in my local version. I didn't rename it to Serra Avatar though, it would be cool to use the separate token image, I think :)

Drafts not being saved

PostPosted: 27 Feb 2009, 19:25
by mtgrares
The draft client still does not save decks properly. almost every time if I dont completely close the game down before building the draft deck, the client forgets the decklists. This is really an important bug to fix, particularly since we know we can save files individual and don't need a binary dump for all drafts ever made, plus all constructed decks, etc.
This probably happens when the you have many decks saved. File reading/writing operations tend to be very complicated and error prone. More than likely deleting your old drafts would help, since it would keep the file smaller and it would be faster to read. I think that closing down the application works because it gives the computer more time to read and write the file.

Ajani - Serra Token

PostPosted: 27 Feb 2009, 19:29
by mtgrares
I just fixed this in my local version. I didn't rename it to Serra Avatar though, it would be cool to use the separate token image, I think.
Well just rename the token to "Serra Token" and name Serra Avatar token picture "Serra_Token.jpg". Also you would have to fix the code in GameActionUtil.checkStateEffects() to check for Serra Avatar or "Serra Token". But I'm not exactly sure how you fixed it so these are just suggestions. Thanks for the good work, all these bug fixes drive me crazy, lol.

Re: Drafts not being saved

PostPosted: 27 Feb 2009, 19:32
by Chris H.
mtgrares wrote:This probably happens when the you have many decks saved. File reading/writing operations tend to be very complicated and error prone. More than likely deleting your old drafts would help, since it would keep the file smaller and it would be faster to read. I think that closing down the application works because it gives the computer more time to read and write the file.
Does the draft decks get saved to the same deck file as the constructed decks? If so, would things get better if they were save to two different decks files.

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 19:35
by mtgrares
Yes all the decks are saved in one file.

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 19:47
by DennisBergkamp
Well just rename the token to "Serra Token" and name Serra Avatar token picture "Serra_Token.jpg". Also you would have to fix the code in GameActionUtil.checkStateEffects() to check for Serra Avatar or "Serra Token". But I'm not exactly sure how you fixed it so these are just suggestions. Thanks for the good work, all these bug fixes drive me crazy, lol.
Actually, Rob Cashwalker came up with a naming convention for tokens, {Color} {PT} {Creature Type}. So, for a 1/1 green saproling, it would be "G 1 1 Saproling" which looks for the jpeg "g_1_1_saproling.jpg". Exceptions are Marit Lage (from Dark Depths), Kelp (Wall of Kelp) and Voja (Tolsimir Wolfblood). Check out the AllTokens.txt file which is in the latest release for a full list.

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 21:34
by Rob Cashwalker
DennisBergkamp wrote:Actually, Rob Cashwalker came up with a naming convention for tokens, {Color} {PT} {Creature Type}. So, for a 1/1 green saproling, it would be "G 1 1 Saproling" which looks for the jpeg "g_1_1_saproling.jpg". Exceptions are Marit Lage (from Dark Depths), Kelp (Wall of Kelp) and Voja (Tolsimir Wolfblood). Check out the AllTokens.txt file which is in the latest release for a full list.
Technically, the other exceptions are tokens generated by the Future Sight spellshapers, like Llanowar Mentor. Basically, any time the token has a specific name.

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 21:38
by Rob Cashwalker
GandoTheBard wrote:Immaculate Magistrate does not actually put counters on the creatures it targets. This is incorrect.
While not correct, we still do not have a good solution for using P/T counters correctly.

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 22:10
by GandoTheBard
mtgrares wrote:
The draft client still does not save decks properly. almost every time if I dont completely close the game down before building the draft deck, the client forgets the decklists. This is really an important bug to fix, particularly since we know we can save files individual and don't need a binary dump for all drafts ever made, plus all constructed decks, etc.
This probably happens when the you have many decks saved. File reading/writing operations tend to be very complicated and error prone. More than likely deleting your old drafts would help, since it would keep the file smaller and it would be faster to read. I think that closing down the application works because it gives the computer more time to read and write the file.
Not a likely scenario as it happens even when the draft deck count is 0. I do think that saving that data to a separate file would be sensible. For each of the different types of deck constructions (sealed, draft, constructed)

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 22:45
by GandoTheBard
I am beginning to wonder if the tinkering with the land smoothing has done something odd to the shuffler. I just played 2 games in a row where I drew all 17 lands and 2-3 nonlands before losing. I don't mind losing because I made an error and paid for it...but land flood is damned near unpredictable normally and can be quite frustrating as one waits to top deck an answer to a threat or a bomb to break a stalemate, etc. Certainly one does not expect to get totally hosed twice in a row. Yes, I have experienced that in tournament but afterwards I was told by several very knowledgable players that my opponent was an expert slight of hand artist and that he was known for "unshuffling" decks. The trick of course is to catch such a cheater, because you really don't want to accuse someone unless you have some kind of proof. Losing isn't proof. Anyway, is the shuffling mechanism suddenly broken?

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 22:51
by Chris H.
GandoTheBard wrote:I do think that saving that data to a separate file would be sensible. For each of the different types of deck constructions (sealed, draft, constructed)
We may want to consider retaining the present "all-decks2" file since this is where we will find our previous constructed decks, both human and AI. I suspect that the quest game might be saved in a separate file.

Having a separate sealed-decks and a draft.decks file might be worth some thought. Would it solve the problem? I do not know.

I have seen a problem with the constructed decks in the Deck Editor. It may be similar.

I can go to the Deck Editor and create and save a constructed deck or delete a constructed deck. If I use the Deck Actions - Close option and go back to the New Game window I can then quit the program and my changes are saved.

If I don't use the Deck Actions - Close option and instead use the GUI_NewGame - Quit GUI_NewGame to quit the game my changes are not saved. They will be missing the next time I launch the game.

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 23:03
by DennisBergkamp
I am beginning to wonder if the tinkering with the land smoothing has done something odd to the shuffler. I just played 2 games in a row where I drew all 17 lands and 2-3 nonlands before losing. I don't mind losing because I made an error and paid for it...but land flood is damned near unpredictable normally and can be quite frustrating as one waits to top deck an answer to a threat or a bomb to break a stalemate, etc. Certainly one does not expect to get totally hosed twice in a row. Yes, I have experienced that in tournament but afterwards I was told by several very knowledgable players that my opponent was an expert slight of hand artist and that he was known for "unshuffling" decks. The trick of course is to catch such a cheater, because you really don't want to accuse someone unless you have some kind of proof. Losing isn't proof. Anyway, is the shuffling mechanism suddenly broken?
Hmm, it shouldn't. All I did was change the way the variable smoothLand is set... This only affects the AI, and basically if it's left as the default (checked), then it should be exactly the same as in the previous version (enabled). Is anyone else noticing anything funny?

On a different subject, I figured I'd take a look at this Draft saving bug you guys were talking about. So I click on Booster Draft, New Draft, then start going through the booster packs and building my deck (this is a lot of fun by the way!). It then asks me to name my deck. So I give it a name, and click save (or "OK" or whatever). When I select the deck I just created in the Main Menu, and click Start Game, my hand and library size are 0. Help! Am I doing something wrong here, or is this exactly the bug you guys are talking about?

EDIT: Another different subject, is it correct if I have a Flagstones of Trokair in play, and I play another (they both get destroyed), I get to search for two plains ?

Re: Current Known Bugs list

PostPosted: 27 Feb 2009, 23:37
by GandoTheBard
Im continuing to notice a huge landslide with draws. Most of the time it doesn't matter as the AI doesn't play very well or build good draft decks but it is quite annoying. I am wondering if anyone else has noticed this.