Re: Magic Data
In language_english.xml, the type entry for Abattoir Ghoul says "Creature â~@~T Zombie", not "Creature - Zombie". There are no doubt other instances of a borked '-' character.
High Quality Resources for Collectible Card Games and Home of the CCGHQ Team
https://www.slightlymagic.net/forum/
https://www.slightlymagic.net/forum/viewtopic.php?f=27&t=1347
Why have some cards with ASCII dash, some with UTF-8 long dash? Why not make them all consistent?Arch wrote:The Abattoir Ghoul is due to your editor/viewer. The sign there is a long dash and will not be displayed correctly if your viewer can handle or isn't set to UTF-8.
I assume you noticed that dual cards are duplicated. That is, there are two copies of "Reckless Waif multi Merciless Predator" in cards.xml, language_*.xml, and meta.xml. Is there supposed to be a second, "Merciless Predator multi Reckless Waif" instead?Arch wrote:The presentation in language_english.xml is a bug. (Also exists in cards.xml.) The correct format is used by for instance "Reckless Waif".
Good to know. I'll run it anyways. I haven't been exercising that part of the program that much yet so I want to see that I don't run out of memory or something like that.Ark wrote:You might want to hold off on getting data from Gatherer for GTC. There are about 30+ cards (not in GTC though) where the mana costs was changed to 3U instead of the proper cost, and the rulings for GTC aren't up yet.
The language files were added just recently and are probably pretty far from great. If you want a decently tested piece of magic data you should look at cards.xml instead. I don't know where the language files will go in the future, the only thing that's clear is that they have lower priority than cards.xml. Regarding the inconsistencies in general I'll have to direct you to wizards.randian wrote:Why have some cards with ASCII dash, some with UTF-8 long dash? Why not make them all consistent?Arch wrote:The Abattoir Ghoul is due to your editor/viewer. The sign there is a long dash and will not be displayed correctly if your viewer can handle or isn't set to UTF-8.
Multiples were reported here: viewtopic.php?f=27&t=1347&start=285#p107998 The format is (was) defined here https://github.com/karmag/loa/blob/ec0e ... format.txtrandian wrote:I assume you noticed that dual cards are duplicated. That is, there are two copies of "Reckless Waif multi Merciless Predator" in cards.xml, language_*.xml, and meta.xml. Is there supposed to be a second, "Merciless Predator multi Reckless Waif" instead?Arch wrote:The presentation in language_english.xml is a bug. (Also exists in cards.xml.) The correct format is used by for instance "Reckless Waif".
The basic unit here is the "card". The flip, transform, double side of the card can not exist on it's own. There's no "Merciless Predator" card, it's just a facet of "Reckless Waif".randian wrote:I still don't see what the "multi" construct gains you. It needlessly complicates the logic.
Any eta for mtg-data.txt?Arch wrote:Updated. Still beta though.