HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2018/01/29)

[satsuki]

Hello.
I'm checking generated card (done 4 folders for now) and some crop picture doens't seems to works
"Shapeshifter" and "Llanowar Elves"
I've checked them and no picture in any magic extension.
Of course i have the crop picture for these cards

there both in the tokens.csv so maybe it's related ?

Thanks

[ahkren]

New version uploaded with OGW English cards

[ahkren]

@satsuki it's related. ArtDB has some issues that I haven't quite worked out with cards that have the same name as tokens.

[ahkren]

Ok, I think I got it.
Change ArtDB.php line 107 to

Code: Select all

         $tokenAndCard = array('Kobolds of Kher Keep', 'Festering Goblin', 'Goldmeadow Harrier', 'Llanowar Elves', 'Metallic Sliver', 'Spark Elemental', 'Cloud Sprite', 'Illusion', 'Shapeshifter');

and line 110 to

Code: Select all

            if ((array_key_exists(strtolower($name), $titleToToken) && in_array($name, $tokenAndCard) == FALSE) || (in_array($name, $tokenAndCard) && ($set == 'FUT'||$set == 'C13'||$set == 'TSP'||$name == 'Illusion' && $set != 'APC'||$set == 'C15'||$set == 'LRW'))) {

[satsuki]

thanks.
I launch the generate all again with this new version ^^

[satsuki]

The generate all is on the go but a found a bug in land generation.
The basic land title aren't translated anymore:


The UNH land text isn't centered


the full art land and UGL to are not well texted (the illustrations are ko but that's my crop fault):



The futuresight render is almost perfect, but the copyright and artist is on the left instead of the right


Thanks a lot

[satsuki]

I also have the same bug than with the token but with the cards:

Code: Select all

Spark Elemental [FUT]...*art not found*..
ERROR: Symbol image not found: ImgAcuteEL├®MENTALspaceD┬ÇÖ├®TINCELLES

[Edit]My bad, it's the token generation again, but since the update the token are generated with the card and not after[/Edit]

[satsuki]

card generation alway on the go ^^
Got missing land color :
"Paliano, the High City" > A
Encroaching Wastes > C

[ahkren]

Forest generates with french title when I try and generate it. Do you have output.english.title.on.translated.card set to 1 in config.txt?

For the BFZ land change M15Renderer.php line 321-323 from

Code: Select all

         $typearray = explode(' ',$card->type);
         $type1 = $typearray[0] . ' ' . $typearray[1];
         $type2 = @$typearray[3];

to

Code: Select all

         $typearray = preg_split('/([—:～])/u', $card->type);
         $type1 = $typearray[0];
         $type2 = @$typearray[1];

For the UNH centering change EighthRenderer.php line 233 from

Code: Select all

         $this->drawText($canvas, $settings['title.center.' . strtolower($card->set) . '.x'], $settings['title.center.' . strtolower($card->set) . '.y'], $costLeft - $settings['title.center.' . strtolower($card->set) . '.x'], $card->getDisplayTitle(), $this->font('title'));

to

Code: Select all

         $this->drawText($canvas, $settings['title.center.' . strtolower($card->set) . '.x'], $settings['title.center.' . strtolower($card->set) . '.y'], $costLeft - $settings['title.center.' . strtolower($card->set) . '.x'], $card->getDisplayTitle(), $this->font('title', 'centerY:true centerX:true'));

and change config-eighth.txt under [layout - fullartbasicland]

Code: Select all

title.center.unh.x = 368
title.center.unh.y = 27

UGL is going to take some more time to figure out. I had started it, then forgot about it.

[ahkren]

Futuresight has been giving me a headache, every time I try and right justify the text, it disappears. Still working on it though.

[satsuki]

Thanks ! the corrected lands are almost ok now (only bug is for full art pre-M15 like ZEN fullart land - same issue as the bzf sample i posted)
(have you an idea why some special colors lands was missing in this release but not in the older one ?).

The the basic land name it was my faut, i'm working on a custom french.csv to have 100% translated cards and use new colorless mana symbol ^^ but missed to del untranslated basic land name

I'll wait for the UGL land and Futuresight, take your time, i just wanted to let you know about the bug ^^ , it's great to have Futuresight desing for Futuresight cards even if it's not 100% accurate.

[ahkren]

Eighth edition frames is the same fix as M15 frames
EighthRenderer.php line 278-280 change

Code: Select all

         $typearray = explode(' ',$card->type);
         $type1 = $typearray[0] . ' ' . $typearray[1];
         $type2 = @$typearray[3];

to

Code: Select all

         $typearray = preg_split('/([—:～])/u', $card->type);
         $type1 = $typearray[0];
         $type2 = @$typearray[1];

As for Land colors, I'm not sure what happened there. It's possible I overwrote a line when adding a new land.

[satsuki]

Working too !
i'm going to start to check the card generated in a couple of days, if i found bugs, i know where to report them ^^

thanks again

[GrovyleXShinyCelebi]

The land count thing seems to be because some of the lands weren't added to data/titleToLandColors.csv:

Paliano, the High City
Radiant Fountain
Sliver Hive
Encroaching Wastes

Adding these lands to the .csv or scripts eliminated the error.

In addition some of the lands appear to have quotation marks around them when viewing data/titleToLandColors.csv with a text editor which can interfere with the scripts' ability to find them. I know three of them were Nivix, Aerie of the Firemind, Novijen, Heart of Progress, and Prahv, Spires of Order; they caused the generator to crash.

[ahkren]

The quotes around the items are to designate the item as a single line instead of splitting the title on the comma, which would cause an error. Any title that has a comma in it should be surrounded with ""

Attached is an updated titleToLandColors.csv