Page 2 of 24

Re: HQ Cardgen M15/Eighth/PreEighth (Updated 10/17/2015)

PostPosted: 25 Oct 2015, 19:56
by ggwithrow
xenagos.JPG


Xenagos, the Reveler seems to end up with an incorrect text box also.

Re: HQ Cardgen M15/Eighth/PreEighth (Updated 10/17/2015)

PostPosted: 25 Oct 2015, 22:12
by ahkren
ggwithrow wrote:Getting an error


ERROR: Land color missing for card: Mana Confluence
Fixed, thanks.

Extract to data/titleToLandColors.csv

Re: HQ Cardgen M15/Eighth/PreEighth (Updated 10/17/2015)

PostPosted: 26 Oct 2015, 01:45
by ahkren
Uploaded new version with fixes to eighth edition planeswalker renderer and added missing land colors

Re: HQ Cardgen M15/Eighth/PreEighth (Updated 10/25/2015)

PostPosted: 27 Oct 2015, 15:29
by Gahedros
Any chance it would be possible to update the .csv files for other languages to support newer sets?

Re: HQ Cardgen M15/Eighth/PreEighth (Updated 10/25/2015)

PostPosted: 28 Oct 2015, 07:22
by ahkren
It is possible if I could find updated MWS foreign translation files. I have had no luck finding any that are updated that I can parse.
The longer way would be for me to write a parser for Gatherer Extractor, which has the upside of not needing MWS as a middleman, the downside would be that it will take a while as I will have to figure out exactly how to do that.

Re: HQ Cardgen M15/Eighth/PreEighth (Updated 10/25/2015)

PostPosted: 30 Oct 2015, 09:31
by ahkren
I've worked out parsing a complete dump of a Gatherer Extractor file. Hopefully someone can test this out, I have some familiarity with the languages, but am certainly not fluent. I have no idea if Traditional Chinese, Simplified Chinese, Japanese or Korean work as I don't have the proper font to render them.
I hope I got the parsing on the Gatherer Extractor csv correct. It looks decent from a cursory examination.

JaceBeleren-Bold.ttf or BelerenB.ttf both work, JaceBeleren-Bold.otf does not.

Feedback is most welcome.

Re: HQ Cardgen M15/Eighth/PreEighth (Updated 10/25/2015)

PostPosted: 30 Oct 2015, 14:46
by Gahedros
ahkren wrote:I've worked out parsing a complete dump of a Gatherer Extractor file. Hopefully someone can test this out, I have some familiarity with the languages, but am certainly not fluent. I have no idea if Traditional Chinese, Simplified Chinese, Japanese or Korean work as I don't have the proper font to render them.
I hope I got the parsing on the Gatherer Extractor csv correct. It looks decent from a cursory examination.

JaceBeleren-Bold.ttf or BelerenB.ttf both work, JaceBeleren-Bold.otf does not.

Feedback is most welcome.
Thank you very much!

I have been doing some testing and I have noticed some problems while trying to generate the full Innistrad set in spanish:
  • Double sided cards such as Cloistered Youth are being generated as only one card (I have tested that the english version is correctly generated as two separate sides).
    Cloistered Youth.jpg
  • Before the generation starts, I am getting a lot of "Error matching card flavor for card:" for many different cards (before the decklist is even parsed).
  • While generating "Garruk Relentless" the generation crashes with error "ERROR: Background image not found for color "Gld"".


On the other hand, all text (including written accents and ñ) seems flawless.

Re: HQ Cardgen M15/Eighth/PreEighth (Updated 10/25/2015)

PostPosted: 30 Oct 2015, 16:32
by ahkren
Good to know that the text is right. I'll have to mess around with the parser. I don't think it's combining double faced cards, I'll have to see what I can do to correct that.

Re: HQ Cardgen M15/Eighth/PreEighth/Tokens (Updated 2015/11/

PostPosted: 08 Nov 2015, 05:51
by ahkren
Fixed a couple errors I found in the language files with the Origins spark walkers.

Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2015/11/07)

PostPosted: 12 Nov 2015, 19:03
by Randomage
When it comes to centering the text, can you bump the check from < 40 to < 44?

Just so the reminder for original duals can be centered.

Also, when checking whether to add the bottom hologram, I added "B" and "S" rarities, based on the name of the Vintage Masters rarity symbols.

Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2015/11/07)

PostPosted: 13 Nov 2015, 02:58
by ahkren
@Randomage
Can do for next upload. Just packaged one for release today.

Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2015/11/12)

PostPosted: 15 Nov 2015, 02:57
by Randomage
More feedback for next release:

cards.csv
| Open
A lot of small mistakes for VMA cards, there's no reminder text for the duals, for instance
Code: Select all
Bayou,VMA,Lnd,Land — Swamp Forest,,,R,,,,Karl Kopinski,293\325,
should be
Code: Select all
Bayou,VMA,Lnd,Land — Swamp Forest,,,R,,#({T}: Add {B} or {G} to your mana pool.)#,,Karl Kopinski,293\325,
Counterspell has no flavor text.
Code: Select all
Counterspell,VMA,U,Instant,,,C,{U}{U},Counter target spell.,,Jason Chan,64\325,
should be
Code: Select all
Counterspell,VMA,U,Instant,,"The pyromancer summoned up her mightiest onslaught of fire and rage. Jace feigned interest.",C,{U}{U},Counter target spell.,,Jason Chan,64\325,
Flavor text removal feature
| Open
Add the following line in config.txt
Code: Select all
card.flavor.disable = 0
in CardDB.php, fucntion configureCard, replace
Code: Select all
      if ($config["card.flavor.random"]) {
with
Code: Select all
      if ($config["card.flavor.disable"]) {
         $card->flavor = '';
      } elseif ($config["card.flavor.random"]) {
I also suggested to increase the check for characters from 40 to 44 so the dual reminder text would end up being centered, but it ended up wrecking something else, bottom line, it's not an amazing system, a better option should be investigated.

In various renderers, I'm not sure what is the point of this check
Code: Select all
if ($card->isBasicLand() || ($card->isLand() && $card->legal == '' && $card->flavor == '') ) {
over this check
Code: Select all
if ($card->isBasicLand()) {
but it broke my ability to have dual lands without the mixed mana symbol (they are lands with no text and no flavor at times)

Lastly, the theros gods stars check should include C15.

I'm half of the mindset to help completely rewrite the watermark/alternate frame systems.

Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2015/11/12)

PostPosted: 19 Nov 2015, 11:59
by Jahill
Is it possible to create Planeswalker cards using createCard.bat?
Also, createCard.bat returns an error after completion in version 9.0.05.
Image

Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2015/11/12)

PostPosted: 19 Nov 2015, 20:11
by ahkren
@Jahil at the moment, no, it is not. I have not worked on getting the createCard functions kept up with the rest of the program yet. It is on the to do list. I've been trying to get the main renderers working and all sets functioning with all versions of cards. I've been working on a new release with futureshifted cards, which should be ready in another week or so. I'm going to be at OryCon this weekend and Thanksgiving in the US next week, so I won't have much time to work on this until after then.

Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2015/11/12)

PostPosted: 20 Nov 2015, 07:54
by Jahill
Fair enough. Have a good one.