2.9.2 sitescripts
Posted: 06 Mar 2014, 01:38
High Quality Resources for Collectible Card Games and Home of the CCGHQ Team
https://www.slightlymagic.net/forum/
https://www.slightlymagic.net/forum/viewtopic.php?f=32&t=8174
libver="2.9"
libver="2.10"
I have a feeling you have a dartboard at home with "Bloodnut" placed in the centerLordHelmchen wrote:This should stabilize development for a while, unless Bloodnut finds another bug
Bloodnut wrote:All scripts seems to work well... surprisingly!
If you are referring to the one you reported [2nd March, that should have been fixed in libver 2.9:EDIT: well, if you don't count that bug where you only download either foil-only or non-foil only but it's not "mission critical".
In all other cases: Would you care to elaborate? I don't see anything unusual in either of the three modes:library changelog 2.9 wrote:fixed and improved MergeCardrows (was broken if importfoil=="N" or "O" - reported by Bloodnut)
magicuniverseDE.lua:
regular only: 17341 set, 11 failed English cards 15886 set, 16 failed German cards 19 set, 0 failed Italian cards ; 1116 dropped, 140 namereplaced and 0 foiltweaked.
foil only : 8010 set, 407 failed English cards 8001 set, 416 failed German cards 0 set, 0 failed Italian cards ; 0 dropped, 35 namereplaced and 0 foiltweaked.
both : 17342 set, 418 failed English cards 15887 set, 423 failed German cards 19 set, 0 failed Italian cards ; 1116 dropped, 175 namereplaced and 0 foiltweaked.
expected : 17342 set, 418 failed English cards 15887 set, 423 failed German cards 19 set, 0 failed Italian cards ; 1116 dropped, 175 namereplaced and 0 foiltweaked.
mtgmintcard.lua:
regular only: 19774 set, 2 failed English cards 6684 set, 186 failed Simplified Chinese cards ; 847 dropped, 86 namereplaced and 0 foiltweaked.
foil only : 10390 set, 0 failed English cards 5750 set, 0 failed Simplified Chinese cards ; 1 dropped, 13 namereplaced and 2 foiltweaked.
both : 19851 set, 2 failed English cards 6697 set, 186 failed Simplified Chinese cards ; 846 dropped, 99 namereplaced and 4 foiltweaked.
expected : 19851 set, 2 failed English cards 6697 set, 186 failed Simplified Chinese cards ; 846 dropped, 99 namereplaced and 4 foiltweaked.
tcgplayerPriceGuide.lua: *(see below)
regular only: 20351 set, 5 failed English cards ; 165 dropped, 446 namereplaced and 2 foiltweaked.
foil only : 0 set, 0 failed English cards ; 0 dropped, 0 namereplaced and 0 foiltweaked.
both : 20360 set, 5 failed English cards ; 156 dropped, 446 namereplaced and 11 foiltweaked.
expected : 20365 set, 5 failed English cards ; 154 dropped, 446 namereplaced and 11 foiltweaked.
trader-onlineDE.lua:
regular only: 19788 set, 2 failed English cards 17939 set, 13 failed German cards 429 set, 0 failed Italian cards ; 823 dropped, 235 namereplaced and 0 foiltweaked.
foil only : 8310 set, 0 failed English cards 6488 set, 0 failed German cards 0 set, 0 failed Italian cards ; 531 dropped, 74 namereplaced and 0 foiltweaked.
both : 19797 set, 2 failed English cards 17940 set, 13 failed German cards 429 set, 0 failed Italian cards ; 1345 dropped, 311 namereplaced and 9 foiltweaked.
expected : 19797 set, 2 failed English cards 17940 set, 13 failed German cards 429 set, 0 failed Italian cards ; 1347 dropped, 311 namereplaced and 9 foiltweaked.
Total counted : 9 set, 0 failed English cards ; 20507 dropped, 0 namereplaced and 9 foiltweaked.
Ok, I can see what might be happenning and it's easy to construct it so that there's no reason for the script to error out here. I will change the lib to prevent this error in the future (without changing the version number).Bloodnut wrote:notice in the screenshots that when I select to download 'regular' the error says 'foilprice' (line 1022) but when I select 'foil' the error says 'regprice' (line 1021)
if card.names then card.names[lid]=nil end
if card.regprice then card.regprice[lid]=nil end
if card.foilprice then card.foilprice[lid]=nil end