About removing Global Ruin

by **Max mtg** » 19 Mar 2013, 10:06

We have a harcoded spell Global Ruin that is the only user of a field:
forge.card.spellability.SpellAbility.beforePayMana

If we remove both the spell and that field, the code will become somewhat simplier.

What do you think?

by **friarsol** » 19 Mar 2013, 12:17

As much as I'd love to just remove cards that were hardcoded poorly, it could break any number of decks and any number of quest modes. I'll put Global Ruin on the top of my convert to script list. (It was already near the top for other reasons)

by **Max mtg** » 19 Mar 2013, 17:33

That's a pity we can't throw away poorly coded cards.
I'll await your action on global ruin.

And thank you for dealing with championing ability, the code looks neater now.

by **friarsol** » 20 Mar 2013, 01:37

That converted a lot easier than I expected it to. I didn't do any cleanup with beforePayMana or other related things.

by **Max mtg** » 20 Mar 2013, 04:40

Thank you, Sol! I have removed all reference to beforePayMana in r20489