Combat.java - wrong implementation

[Max mtg]

Code: Select all

private List<Card> combatantDealtFirstStrikeDamage = Lists.newArrayList();

Should not be in Combat class. It refers to card damage history if a card was dealt first-strike damage.

[friarsol]

Code: Select all

private List<Card> combatantDealtFirstStrikeDamage = Lists.newArrayList();

Should not be in Combat class. It refers to card damage history if a card was dealt first-strike damage.

No, it doesn't. It refers to whether a Card assigned damage during the first strike damage, not whether it received damage. It's needed in the Combat class to determine if a creature will deal damage in the non-first strike damage, since before this we were incorrectly just checking if creatures had first strike, which is not correct since if a creature gains or loses first strike it wouldn't correctly assign damage the second time.

[Max mtg]

You are right then.

I have slightly renamed the field and added a comment to prevent other people from making wrong conclusions about this code.