What major part needs to be updated?

[mtgrares]

You guys, dennis and rob and others have worked very extensively with MTG Forge's source code and what do you think is the most important part that needs to be updated? Should MTG Forge use the new combat system or have all of the phases and phase stops? Or should I find a way to automatically test and verify cards? I don't mind doing some major work on MTG Forge if I knew which area needed it the most.

[Rob Cashwalker]

Phase stops AND De-hack Dennis' AI for counterspell....
Essentially, allow the AI to use the standard SpellAbility.canPlayAI method during any phase stop. So counterspells would have a canPlayAI that checks if there's a spell on the stack, and if so, then go ahead. Or Pump effects can be revised so that canPlayAI would prefer to be played during combat.

[mtgrares]

That's probably as good as the AI Counterspell can get. I don't see another way of doing it.

AI combat tricks like instants and activated abilities really interests me but I know that it is a big task because it is hard to really put your finger on how things should work.

Having all phases and phase stops in MTG Forge sounds good. If I'm brave I'll work on it.

[Rob Cashwalker]

Keep in mind, that you asked for a really major part. This one part encompasses a number of features and changes. But I'm fairly sure the architecture can handle it.

I don't see why it couldn't work something like what I'm describing.

On the other hand, this would require changing current canPlayAI methods, because most if not all of them assume to be played as sorceries on the computer's turn. Therefore, they need to check more than just "Am I a useful spell?" They need to make sure the timing is right. This could be partly mitigated by only checking the canPlayAI for instants and permanent abilities. (filtering out sorceries and planeswalkers)

Dennis has already begun some work towards supporting multiple comes-into-play abilities, allowing for either cards with two CIP abilities, or other effects granting or replacing CIP abilities to other cards. Similar approaches could be modeled to allow for many other triggered abilities or replacement actions. Once implemented, an event would be triggered when just about anything occurs, and therefore could be used to provide the AI a chance to respond to just about anything.

Along with the spDamageTgt code, I included DamagePlayer and LoseLife methods in GameAction, to provide a placeholder for any future support for prevention and redirection; similar in theory to the DamageCreature method implementation for Wither. Another major part you could brainstorm would be prevention and redirection effects. (seems like mostly input routines)

[silly freak]

i think we should extrack a canPlay method out of canPlayAI to check things like timing that are common to both players

[DennisBergkamp]

Currently the ManaPool needs fixing, I'd say...

[Resonantg]

Only thing I can think of that really would be a big difference is Upkeep both normal and cumulative.

[zerker2000]

Concerning that, I would say that field pumpers(Soldiers, Slivers, Lords...) should also be keyworded in some way, possibly using a StaticEffect class that does so(e.g. CardListFilter affects, void(Card) affect).

[mtgrares]

On a smaller level, I should be able to add a "phase stop" for "After the Computer Declares Attackers." Basically I'll just cut and paste the End of Turn code in InputControl. Maybe I can also make the OK button wait a second or two so that people don't click too fast. And I should be able to make the right mouse button automatically click the OK button, that might save a few miles. (I think that was a feature of the short-lived online version.)

[DennisBergkamp]

On a smaller level, I should be able to add a "phase stop" for "After the Computer Declares Attackers." Basically I'll just cut and paste the End of Turn code in InputControl. Maybe I can also make the OK button wait a second or two so that people don't click too fast. And I should be able to make the right mouse button automatically click the OK button, that might save a few miles. (I think that was a feature of the short-lived online version.)

This is actually already in the latest Beta, except it's not optional (like the EoT one), but it will occur only whenever the computer attacked with creatures.

[mtgrares]

OK, thanks for telling me. I think I remember reading it but then people were having problems installing it, so I never installed it.