Cantrips

[Chris H.]

I want to thank everyone for helping out with this portion of the project. I used Rob's suggestion for the test. At one time I had a local version which was fairly close to his, and then I got swept up with reading up on String Builder in the javadoc.

I think that I found all of the cards that used the old cantrip keyword and the cards that were hard coded. They all should have been converted over.

[DennisBergkamp]

Dennis - when you made this method for the counterspells,
why did you include a Cantrip check? The spellability is added to the stack in this code, but it hasn't been resolved yet. The Cantrip (and now the scry code I'm adding) should execute only after the spellability.resolve method is executed.

Ah, wasn't thinking clearly I suppose I was happy I got the AI to counter stuff in the first place!
Looking at the code, I'm not even sure why I added the cantrip code there...

[Rob Cashwalker]

To be honest, I'm not happy that there are two locations where sa.resolve occurs. I know it's a difference due to ai player and human player, but it sucks as a concept...

[DennisBergkamp]

Hmm, agreed, it's a bit of a hack, and ideally it would be in one single place, but I don't really see any other way of doing it.
By the way, I did not add the playNoStack method, it's always been there, the only code that seems to have been using it is in SpellAbilityList.java.

I use playNoStack(sa) only for the AI to pay for optional costs: the invasion Legendary Dragons, paying for Propaganda, Upkeep/Echo and possibly responding to spells like Daze / Mana Leak.