It is currently 09 Sep 2025, 04:45
   
Text Size

GameActionUtil.java indentation

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

GameActionUtil.java indentation

Postby slapshot5 » 10 Apr 2010, 22:21

Hi all,

The indentation of GameActionUtil.java for me in Eclipse is all screwed up. See screenshot.

Image

Am I the only one seeing this? I just Ctrl+A then Source > Correct Indentation in Eclipse.

If others are seeing this, perhaps doing the above actions and checking it in would fix this?

Thanks,
slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: GameActionUtil.java indentation

Postby DennisBergkamp » 10 Apr 2010, 22:27

Yeah, this happened because Silly Freak's Eclipse messed with it :)
I'll fix it using your suggestion, and commit the changes.
User avatar
DennisBergkamp
AI Programmer
 
Posts: 2602
Joined: 09 Sep 2008, 15:46
Has thanked: 0 time
Been thanked: 0 time

Re: GameActionUtil.java indentation

Postby Rob Cashwalker » 11 Apr 2010, 01:51

It's funny... what one person calls "correct indentation" isn't what others would consider "correct".
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: GameActionUtil.java indentation

Postby silly freak » 11 Apr 2010, 11:36

I of course consider it correct^^ no, the reason for this is that I have configured my eclipse to format source code automatically on a save. It looks good most of the time, but unfortunately often not for anonymous classes... sorry, i'll see if I can tweak my formatter settings ;)
___

where's the "trust me, that will work!" switch for the compiler?
Laterna Magica - blog, forum, project, 2010/09/06 release!
silly freak
DEVELOPER
 
Posts: 598
Joined: 26 Mar 2009, 07:18
Location: Vienna, Austria
Has thanked: 93 times
Been thanked: 25 times

Re: GameActionUtil.java indentation

Postby Rob Cashwalker » 12 Apr 2010, 03:20

Right, but it's more comical that Eclipse has a function called "Correct Indentation", but of course it's really just following your personal preferences. Since Eclipse has no way to import preferences, then what if you were to need to switch your formatting to follow a company policy for standard formatting?

Most open source projects have a formatting policy and naming conventions outlined in the documentation. Granted, we're not like most open source projects, but you can understand why they do....
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: GameActionUtil.java indentation

Postby silly freak » 12 Apr 2010, 05:55

actually, you can import/export preferences, though I wished it was more uniform. the Formatting can be exported from the formatter page, but not via File/Export...
___

where's the "trust me, that will work!" switch for the compiler?
Laterna Magica - blog, forum, project, 2010/09/06 release!
silly freak
DEVELOPER
 
Posts: 598
Joined: 26 Mar 2009, 07:18
Location: Vienna, Austria
Has thanked: 93 times
Been thanked: 25 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 34 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 34 users online :: 0 registered, 0 hidden and 34 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 34 guests

Login Form