Thought Devourer bugs / Maximum hand size bugs

[zaroblan]

Greetings,

While playing a quest the other day I played a Thought Devourer (which reduces your maximum hand size by four). The problems I encountered were:

1) the text shown at the end of turn when you need to discard always shows 7 as the maximum hand size
2) your maximum hand size is not reset between games
3) your maximum hand size is not reset between matches

Even after exiting quest mode and starting a constructed game, my hand size limit was still set to 3.

I do not know if any of the other cards which affect your, or your opponents, maximum hand size experience these problems but I will be testing it out.

Thanks for an awesome new update. The new cards are cool.

Ned Flanders Level 3 reanimator deck was a bit of a shock to come up against though. Staring down a reanimated Simic Sky Swallower on turn 2 was quite an eye opener

Keep up the good work guys!

Robert Lancaster

[Hellfish]

Just to make sure, are you running the latest release? (07/16)

This was reported before and I submitted a fix which Chris implemented into that release. I just tested it in constructed and it worked fine, except the message problem you mentioned I will test it in quest mode (if this computer is up to it) as well. In the meantime, here's a fix for the message:

Change line 94 of Input_Cleanup.java from:

Code: Select all

AllZone.Display.showMessage("Cleanup Phase: You can only have a maximum of 7 cards, you currently have "


to:

Code: Select all

AllZone.Display.showMessage("Cleanup Phase: You can only have a maximum of " + MaxHandSize + " cards, you currently have "


EDIT: It works fine in quest mode as well. I suggest updating to 07/16

[Chris H.]

I think that Zaroblan is likely using the older 06-26 version. Upgrading to the newest 07-16 version will fix the problem of the hand size adjustment carrying over to the next game or match.

Forge 07/16/2010 (unofficial BETA) version

I will merge in Hellfish's new code fix later on today. It is currently 6:30 am in my section of the world and I am still working on my first cup of coffee.

[Chris H.]

I will merge in Hellfish's new code fix later on today. It is currently 6:30 am in my section of the world and I am still working on my first cup of coffee.

`
OK, I merged in the fix and while I was there I got a wee bit carried away, but in good style I hope. I changed this over to using StringBuilder:

Code: Select all

        StringBuffer sb = new StringBuffer();
        sb.append("Cleanup Phase: You can only have a maximum of ").append(MaxHandSize);
        sb.append(" cards, you currently have ").append(n).append(" cards in your hand - select a card to discard");
        AllZone.Display.showMessage(sb.toString());
       
        // AllZone.Display.showMessage("Cleanup Phase: You can only have a maximum of 7 cards, you currently have "
        //         + n + " cards in your hand - select a card to discard");