JAR creation failed

[Chris H.]

I updated my local copy to rev 1656. As I was exporting a runnable JAR file I received a message that the JAR creation failed. I captured a screen shot which is below.

The JAR file does export and runs. I guess that I could ignore this error. It appears that Mana_PayCost.java was merged with ManaCost.java. As such, it is no longer a class file.
`

[friarsol]

Yea since ManaCost was an extremely thin wrapper over Mana_PayCost it made sense just to merge the two files, since PayCost wasn't used anywhere on it's own. I guess we should just remove Mana_PayCost from the JAR file creation setup? I didn't want to just remove it because I didn't want the file history to be lost.

[DennisBergkamp]

Chris,

What I did is just delete Mana_PayCost from my local copy. JAR gets created no probs

[Rob Cashwalker]

I don't think all history for a file is lost if it's deleted even from the SVN. I'm sure it's still stored in the archive.

[friarsol]

I've been on systems where this wasn't the case (or you had to recreate the filename before the history became available again). Since I wasn't sure I decided to play it safe.

If it'll be easier for everyone we should just nuke the file.

[Chris H.]

I played with last night before going to bed.

When I update my local copy I will create a zip archive of the then current SVN project. As such, I was able to quickly unzip an archive and I peeked at the old class file. It came to me that we could make a minor mod of the Mana_PayCost class file.

The file now looks like this:

Code: Select all

// merged with ManaCost since it was a thin wrapper// file NOT deleted to keep SVN history available


`
I changed it to this on my local copy:

Code: Select all

package forge;

public class Mana_PayCost {
   
    /**
     *  Merged with ManaCost since it was a thin wrapper.
     *  File NOT deleted to keep SVN history available.
     */
   
}

`
The project built without any problems. The JAR will now export without that weird "the JAR creation failed message". I think that I will merge this into the SVN.

[silly freak]

anyway, the file history is not deleted from SVN when removed. this is the whole point of the system, to be able to restore any previous version.

To restore a deleted file in eclipse, you can right-click on the containing folder and choose "Restore from local history...". To do the same from SVN, I guess you have to update your local copy to the specific revision, or alternately look for the file directly on google code

[Snacko]

However it is possible to alter SVN repo to completely remove a file from history.

[Chris H.]

I think that I will merge this into the SVN.

`
I went ahead and merged my simple solution to the issue. I am just a jr. coder in training and I will allow the more experienced programmers decide whether or not to delete the class from the SVN.