Time to split CardFactory again....

[Rob Cashwalker]

Dennis - can you work your magic again to split instants and sorceries to their own classes? My system is really lagging every time I make some changes, as it's recompiling and trying to suggest syntax....

[Chris H.]

Dennis - can you work your magic again to split instants and sorceries to their own classes? My system is really lagging every time I make some changes, as it's recompiling and trying to suggest syntax....

`
On my copy of Eclipse I decided to uncheck the

Project -> Build Automatically

menu choice. It appears to have sped up my editing efforts. Granted, at some point I have to save the file and select "Build Project" or "Build All". The "Build Automatically" option seems to get in the way.

[Rob Cashwalker]

That only affects things when the file gets saved anyway. It's the in-between time, that I'm having trouble with..
We have so many classes and methods with slight differences in parameters, that I really like eclipse suggesting the available methods. But it only is able to do that in short classes. CardFactory is just so big that eclipse can't deal with it.

Granted, my laptop isn't terribly powerful, a 1.6 Ghz Centrino with 512 MB ram. Desktops probably have no issues.

[DennisBergkamp]

Ah, I'll have a look and see if there's an easy way to do this. The trickiest part would probably be the keyword stuff (almost all of the keyword code in CardFactory are used by both instants and sorceries, this code will have to show up in both CardFactory_Instants and CardFactory_Sorceries), and of course going through every single card.

EDIT: by the way, a lot of the keyword code could probably be externalized... also, there's some places where the code is slightly different, e.g. CardFactory_Creatures still has the old shouldTransmute(card), whereas CardFactory and CardFactory_Lands uses hasKeyword(card, "Transmute").

[Chris H.]

The limited ram might be causing page outs. On my Mac, Eclipse is consuming 375.9 MB of ram. I guess that your laptop might also have a slow speed HD.

Will your computer take additional memory, or is this one of those situations where you would hate to throw more money into an older computer?

[Rob Cashwalker]

Reverse order...

chris - I can only swap out my 512 for a 1 GB... only one slot. And it's an older memory technology, so it's not as cheap as the new stuff. Beleive me, I've been wanting to do that for a while.. it's technically not entirely mine, though I paid for a replacement battery and power adapter.

Dennis - if we could split the keywords to their own class prior to processing other instants and sorceries, would that solve that problem?
Or in general, if any sub-factory doesn't match the card, then it would try the keywords.
Given the outline, you don't have to do the leg-work of copying the code.

[DennisBergkamp]

Actually, it's not as bad as I thought, obviously the ~5k lines of keyword code at the beginning of CardFactory get executed before they point to the different CardFactories (so they're just required in one place only). For Instants/Sorceries, there will only be a few keyword checks at the end (Transmute and (type)Cycling are the only ones I think).

On a related note, CardFactory_Creatures is getting quite big also...

[Rob Cashwalker]

Cool beans. CardFactory may become just keywords, until the keywords themselves become troublesome...

So for the creatures, can we split it by alphabet? A-L go in one class, M-Z to another?

[DennisBergkamp]

Yes exactly.
As for the creatures, we could split them alphabetically, we could split them by color (W U B R G, multi, colorless), there's many options.

[Rob Cashwalker]

Oooohh the colors dude... look at the colors!

[DennisBergkamp]

Double Rainbow

Anyway, I just finished splitting this thing up... it should make a big difference, it's "only" 9500 lines now (5500 for the instants, 8200 for the sorceries). I also got rid of all of the commented out cards.

[Rob Cashwalker]

That should help immensly. Thank you.

[Chris H.]

Wow, I went to bed early last night. And find that Dennis was able to get this done last night. Thank you.