Obsolete Keywords

[friarsol]

(This originally started off as a post regarding the Spike keyword, but really applies for any obsolete keywords.)

The Spike keyword is really a combination of two different keywords. etbCounter which exists and abPutCounter which probably will in the near future.

In most cases we're making code blocks into keywords, so those blocks just get removed from the code.
But some of the ones I've been thinking about doing are combining keywords that can now be a single entry due to Ability_Cost being able to handle the cost portion.

There's a bunch of different addMana abilities which can easily fit into a single keyword

Code: Select all

{cost}, Sacrifice CARDNAME: Add {mana} to your mana pool.
{cost}, {tap}: add {mana}
paintap:{damage number}:{mana}
tap: add 1
tap: add B
tap: add G
tap: add R
tap: add U
tap: add W


"1, Sacrifice CARDNAME: Draw a card." keyword can be merged into abDrawCards[Tgt] once it starts using Ability_Cost and Target.

"Remove three spore counters from CARDNAME: Put a 1/1 green Saproling creature token onto the battlefield." should be generalized into an abCreateToken

So how about we make a list of keywords that should be generalized, or some of the ones that need Ability_Cost added to them?
Once we have a decent list, it should be pretty easy to convert the old keywords into a unified one, or take an existing keyword and just add usage of Ability_Cost to it.

[zerker2000]

There's a bunch of different addMana abilities which can easily fit into a single keyword

Just saying:

tap: add 1
tap: add B
tap: add G
tap: add R
tap: add U
tap: add W

These should already be treated as

Code: Select all

{cost}, {tap}: add {mana}

[Chris H.]

There are some other cases where we may want to at some point combine a number of keywords into a single keyword. The attacking/blocking keywords for example.

I suspect that tap: add {mana} may have been one of the first keywords to be written.