Phase Work

[friarsol]

r3399: I attack with my Wolf Pet. There's nothing visible to indicate that the computer's creatures, which are a Knight of the Skyward Eye and a Knight of the White Orchid, are blocking, but each creature receives a -1/-1 as if they blocked my Pet. The computer still loses life as if the Pet wasn't blocked and the Pet and the computer's creatures are still alive.

I had noticed this a few times but was having a hard time tracking it down. I ended up moving the Flanking (and similar triggers) to the second half of the Declare Blockers Step and it looks like all is well again. For whatever reason, halfway through blocking the blocking decision would retrigger, and blocking assignments would change.

[Chris H.]

Gotcha. The crowdedness was part of the reason I removed the Spell/Abilities line. Combining the first two lines is a cosmetic/non-coding issue that can easily be added back in.
I had separated them because things were too jumbled previously.

We can come to a consensus how the message should be listed since it's only ever displayed for the player. We should get a PM to be in charge of this type of stuff.

It's not tough to put in Human priority during EOT. If anyone wants to try it out feel free to change this section of code in InputControl to:

Code: Select all

else if(phase.equals(Constant.Phase.End_Of_Turn)){
   if (playerTurn.isHuman()){
      //AllZone.Computer.getComputer().end_of_turn();
      //return null;
   }
   else if (priority.isComputer()){
      // AI passes priority in his end of turn phase to player automatically
      AllZone.Phase.passPriority();
      return null;
   }
}


Lemme know if there's any issues with this and I'll dig into it.

`

During some testing I discovered that Wall of Reverence puts up an AllZone.Display.getChoiceOptional() dialog during the Human's end of turn phase. Without your code mod it appears to show up during the Human's main 2 phase.

[friarsol]

It looks like what's happening is that this is always triggering in EOT, but the Input is still stuck on the previous phase, and doesn't update itself. However, this is enough proof that the EOT phase for the player is necessary, so I'll push an update in here now.

[timmermac]

When a forced discard happens due to too many cards in hand, and the card chosen to discard has a madness cost, the game gets to a point where there's nothing that is allowable. screenshot attached.

[friarsol]

When a forced discard happens due to too many cards in hand, and the card chosen to discard has a madness cost, the game gets to a point where there's nothing that is allowable. screenshot attached.

Hmm.. Your right. I'll see what the rules have to say about that and follow that course of action. I think it may be something like "empty the stack until a new phase would happen, and then have another cleanup phase"