How best to contribute?

[sentient6]

I stumbled upon Forge a bit over a week ago and have been throughly enjoying. I would like to contribute to the project in some way and I'm curious about how I could get started with that.

As practice I have written card files for Devastate and Stormwatch Eagle. They are shown below:

Code: Select all

Name:Devastate
ManaCost:3 R R
Types:Sorcery
Text:no text
A:SP$Destroy | Cost$ 3 R R | ValidTgts$ Land | TgtPrompt$ Select target land. | SubAbility$ SVar=DBDamageAll | SpellDescription$ Destroy target land. CARDNAME does 1 damage to each creature and each player.
SVar:DBDamageAll:DB$DamageAll | NumDmg$ 1 | ValidCards$ Creature | ValidPlayers$ Each | ValidDescription$ each creature and each player.
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/devastate.jpg
End

and

Code: Select all

Name:Stormwatch Eagle
ManaCost:3 U
Types: Creature Bird
Text:no text
PT:2/1
A:AB$ChangeZone | Cost$ Sac<1/Land> | CostDesc$ Sacrifice a land | Origin$ Battlefield | Destination$ Hand | Target$ CARDNAME | SpellDescription$ Return CARDNAME to its owner's hand.
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/stormwatch_eagle.jpg
End

Both of them seemed to work when I tested them with a build of the SVN. Are there any corrections I should make?

Additionaly, I was looking at implementing Ashnod's Sacrifice and I was wondering whether it made sense to make an AbilityFactory for mana producing abilities. Sorry if that's a dumb idea.

Anyway, if that's all up to snuff, how would I got about getting the above cards added to the svn repository?

Thanks and keep up the great work.

[friarsol]

It looks like your Eagle is missing Flying. And don't put spacing after the colons. Even though the parser won't penalize you for it in the types. Your Eagle was a third type of "".

I'm guessing you are talking about Ashnod's Altar since Ashnod's Sacrifice doesn't exist. An AF for Mana is in the works (and is mostly complete) but it is a large amount of work (more than any singular AF), and there are some infrastructure issues that still need to be straightened out. Once I have everything worked out, all Mana Abilities will be converted over.

[Chris H.]

We started a topic and stickied it for people to use use when adding cards via the card files found in the cardsfolder. It might be best for people to use this one topic.

Card Development Questions

If you have Eclipse, Subclipse and Subversion installed you can send your google email address to DennisBergkamp via private message and he will give you commit status.

[slapshot5]

Once again, Sol beat me to it. I added these cards to SVN with the tweaks Sol suggests.

-slapshot5

[sentient6]

Ah. Sorry for not posting in the topic at the top. I did indeed mean Ashnod's Altar. Thanks for the information.